Remove some unused pub functions#11576
Merged
charliermarsh merged 2 commits intomainfrom May 28, 2024
Merged
Conversation
Contributor
|
AlexWaygood
reviewed
May 28, 2024
| /// Then, the range `4..10` returns an iterator which yields `Name`, `Lpar`, `Rpar`, and | ||
| /// `Colon` token. But, if the given position doesn't match any of the tokens, an empty | ||
| /// iterator is returned. | ||
| pub fn kinds_within_range<T: Ranged>(&self, ranged: T) -> TokenKindIter { |
Member
There was a problem hiding this comment.
It's possible @dhruvmanila has plans for this one — he added it two weeks ago in 025768d
Member
There was a problem hiding this comment.
Yeah, I'm using this in the new parser PRs. It's fine to remove it here as it has changed a bit, so I'll resolve it during the rebase.
dhruvmanila
approved these changes
May 28, 2024
AlexWaygood
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I left anything in
red-knot, anywith_methods, etc.