Skip to content

Make ruff_notebook a workspace dependency in ruff_server#11572

Merged
MichaReiser merged 1 commit intomainfrom
server-notebook-workspace-dependency
May 28, 2024
Merged

Make ruff_notebook a workspace dependency in ruff_server#11572
MichaReiser merged 1 commit intomainfrom
server-notebook-workspace-dependency

Conversation

@MichaReiser
Copy link
Copy Markdown
Member

@MichaReiser MichaReiser commented May 27, 2024

Summary

The ruff_notebook dependency was added in https://github.dev/astral-sh/ruff/pull/11206

I suspect it's a merge conflict. So lets update the dependency to use the format that Charlie prefers ;)

Test Plan

cargo build

Copy link
Copy Markdown
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup :)

@MichaReiser MichaReiser added the internal An internal refactor or improvement label May 27, 2024
@github-actions
Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser merged commit 3989cb8 into main May 28, 2024
@MichaReiser MichaReiser deleted the server-notebook-workspace-dependency branch May 28, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants