Consider if expression for parenthesized with items parsing#11010
Merged
dhruvmanila merged 1 commit intomainfrom Apr 18, 2024
Merged
Consider if expression for parenthesized with items parsing#11010dhruvmanila merged 1 commit intomainfrom
if expression for parenthesized with items parsing#11010dhruvmanila merged 1 commit intomainfrom
Conversation
MichaReiser
approved these changes
Apr 18, 2024
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug in parenthesized with items parsing where the
ifexpression would result into a syntax error.The reason being that once we identify that the ambiguous left parenthesis belongs to the context expression, the parser converts the parsed with item into an equivalent expression. Then, the parser continuous to parse any postfix expressions. Now, attribute, subscript, and call are taken into account as they're grouped in
parse_postfix_expressionbutifexpression has it's own parsing function.Use
parse_if_expressiononce all postfix expressions have been parsed. Ideally, I think thatifcould be included in postfix expression parsing as they can be chained as well (x if True else y if True else z).Test Plan
Add test cases and verified the snapshots.