Skip to content

[pylint] Omit stubs from invalid-bool and invalid-str-return-type#11008

Merged
charliermarsh merged 1 commit intomainfrom
charlie/is-stub
Apr 18, 2024
Merged

[pylint] Omit stubs from invalid-bool and invalid-str-return-type#11008
charliermarsh merged 1 commit intomainfrom
charlie/is-stub

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

Summary

Reflecting some improvements that were made in #10959.

@charliermarsh charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Apr 18, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) April 18, 2024 01:50
@charliermarsh charliermarsh merged commit 4d8890e into main Apr 18, 2024
@charliermarsh charliermarsh deleted the charlie/is-stub branch April 18, 2024 01:57
@github-actions
Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+3 -0 violations, +0 -0 fixes in 3 projects; 41 projects unchanged)

python/typeshed (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select E,F,FA,I,PYI,RUF,UP,W

+ stdlib/typing.pyi:330:10: PYI001 Name of private `TypeVar` must start with `_`

zulip/zulip (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

+ zerver/lib/validator.py:684:9: PLE0307 `__str__` does not return `str`

indico/indico (+1 -0 violations, +0 -0 fixes)

+ indico/util/passwords.py:69:9: PLE0307 `__str__` does not return `str`

Changes by rule (2 rules affected)

code total + violation - violation + fix - fix
PLE0307 2 2 0 0 0
PYI001 1 1 0 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+7 -0 violations, +0 -0 fixes in 6 projects; 38 projects unchanged)

PlasmaPy/PlasmaPy (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/plasmapy/particles/particle_class.py:174:9: PLE0304 `__bool__` does not return `bool`

apache/airflow (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ tests/models/test_mappedoperator.py:76:13: PLE0304 `__bool__` does not return `bool`

ibis-project/ibis (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ ibis/common/deferred.py:101:9: PLE0304 `__bool__` does not return `bool`
+ ibis/expr/types/core.py:166:9: PLE0304 `__bool__` does not return `bool`

python/typeshed (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select E,F,FA,I,PYI,RUF,UP,W

+ stdlib/typing.pyi:330:10: PYI001 Name of private `TypeVar` must start with `_`

zulip/zulip (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ zerver/lib/validator.py:684:9: PLE0307 `__str__` does not return `str`

indico/indico (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ indico/util/passwords.py:69:9: PLE0307 `__str__` does not return `str`

Changes by rule (3 rules affected)

code total + violation - violation + fix - fix
PLE0304 4 4 0 0 0
PLE0307 2 2 0 0 0
PYI001 1 1 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Related to preview mode features rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant