Change the way the properties are collected using the Class.getMethod…#3135
Closed
amodolo wants to merge 2 commits intoassertj:mainfrom
Closed
Change the way the properties are collected using the Class.getMethod…#3135amodolo wants to merge 2 commits intoassertj:mainfrom
amodolo wants to merge 2 commits intoassertj:mainfrom
Conversation
d5855d3 to
b65a925
Compare
Member
|
Thanks @amodolo, I will do my best to review your PR this weekend ! |
…s() api instead iterating the class hierarchy using Class.declaredMethods(). This way the properties declared in the interfaces will not be ignored.
4ba926c to
edfad62
Compare
Member
|
Integrated thanks @amodolo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I change the way the properties are collected using the
Class.getMethods()api instead iterating the class hierarchy usingClass.declaredMethods().I think that collect the properties using thegetMethodsapi should be a better approach because:Moreover, in this way the properties declared in the interfaces will not be ignored.
Check List: