Add isPrimitive and isNotPrimitive to Class assertions#2722
Closed
ManuelG28 wants to merge 3 commits intoassertj:mainfrom
Closed
Add isPrimitive and isNotPrimitive to Class assertions#2722ManuelG28 wants to merge 3 commits intoassertj:mainfrom
isPrimitive and isNotPrimitive to Class assertions#2722ManuelG28 wants to merge 3 commits intoassertj:mainfrom
Conversation
joel-costigliola
requested changes
Jul 31, 2022
Member
joel-costigliola
left a comment
There was a problem hiding this comment.
Thanks @ManuelG28, first round of code review done. PR looks good, just some minor/improvements comments to address.
assertj-core/src/main/java/org/assertj/core/api/AbstractClassAssert.java
Outdated
Show resolved
Hide resolved
assertj-core/src/main/java/org/assertj/core/api/AbstractClassAssert.java
Outdated
Show resolved
Hide resolved
assertj-core/src/test/java/org/assertj/core/api/classes/ClassAssert_isNotPrimitive_Test.java
Outdated
Show resolved
Hide resolved
assertj-core/src/test/java/org/assertj/core/api/classes/ClassAssert_isNotPrimitive_Test.java
Outdated
Show resolved
Hide resolved
assertj-core/src/test/java/org/assertj/core/api/classes/ClassAssert_isPrimitive_Test.java
Outdated
Show resolved
Hide resolved
...-core/src/test/java/org/assertj/core/internal/classes/Classes_assertIsNotPrimitive_Test.java
Outdated
Show resolved
Hide resolved
...rtj-core/src/test/java/org/assertj/core/internal/classes/Classes_assertIsPrimitive_Test.java
Outdated
Show resolved
Hide resolved
assertj-core/src/test/java/org/assertj/core/api/classes/ClassAssert_isNotPrimitive_Test.java
Show resolved
Hide resolved
assertj-core/src/main/java/org/assertj/core/error/ShouldBePrimitive.java
Show resolved
Hide resolved
added 3 commits
August 1, 2022 09:17
…rimitive() * Add unit tests * Add error
Author
|
Hi, @joel-costigliola thanks for the information about Please let me know if I need to change something else. |
38c7b4b to
3cde5bf
Compare
Member
|
Integrated thanks @ManuelG28 ! |
isPrimitive and isNotPrimitive to Class assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List: