Separate Microsoft.TestCommon more#400
Merged
dougbu merged 1 commit intoaspnet:mainfrom Mar 15, 2023
dougbu:dougbu/even.less.parallel
Merged
Separate Microsoft.TestCommon more#400dougbu merged 1 commit intoaspnet:mainfrom dougbu:dougbu/even.less.parallel
dougbu merged 1 commit intoaspnet:mainfrom
dougbu:dougbu/even.less.parallel
Conversation
- pre-restore and prebuild the project before anything that depends on it - avoid references from other test projects doing any real work - make ordering even more explicit - avoid confusion between batching builds and `$(BuildInParallel)` - turns out this also reduces the number of double writes binary logs show significantly
Contributor
Author
Contributor
Author
|
TeamCity builds were the ones where I mainly saw problems w/ Microsoft.TestCommon. Using this branch, TeamCity builds #561 and #563 of Main.Integration was successful. |
wtgodbe
approved these changes
Mar 15, 2023
Member
|
Trying to find a free port like that will always be racy. It's better for the server to retry binding until it finds a port. |
Contributor
Author
Thanks @Tratcher. Doesn't help my frustration w/ getting this PR in 😉 May either force the merge or just keep retrying until things work. I'm also open to adding a tactical fix here. I'm fine no matter the choice but am not going to dive into finding that workaround myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(BuildInParallel)