Support DBNull in netstandard1.3 assembly#394
Merged
dougbu merged 2 commits intoaspnet:mainfrom Mar 2, 2023
dougbu:dougbu/handle.dbnull
Merged
Support DBNull in netstandard1.3 assembly#394dougbu merged 2 commits intoaspnet:mainfrom dougbu:dougbu/handle.dbnull
DBNull in netstandard1.3 assembly#394dougbu merged 2 commits intoaspnet:mainfrom
dougbu:dougbu/handle.dbnull
Conversation
- available from the System.Data.Common package - extend `DBNull` testing to include `net6.0` - s/NETCOREAPP/NETCOREAPP2_1/ where possible - fix comments in `HttpValueCollectionTest` - comments about `DBNull` there were incorrect
Contributor
Author
|
Thanks to @ajcvickers for his System.Data.Common suggestion❕ Still have an outstanding question to @JamesNK about whether the workaround (hack) in |
wtgodbe
approved these changes
Mar 1, 2023
Contributor
Author
|
Hmm, something is wrong w/ our artifact handling in this pipeline. Can't rerun a single job and I'm not sure why not. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- `publish` / `PublishPipelineArtifact@1` task doesn't overwrite an existing build artifact - bit different from `PublishBuildArtifacts@1` - follow guidance at <https://learn.microsoft.com/en-us/azure/devops/pipelines/artifacts/pipeline-artifacts?view=azure-devops&tabs=yaml-task#q-can-i-delete-pipeline-artifacts-when-re-running-failed-jobs>
mkArtakMSFT
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBNulltesting to includenet6.0HttpValueCollectionTestDBNullthere were incorrect