Rename Formatting projects and more#392
Merged
dougbu merged 4 commits intoaspnet:mainfrom Feb 28, 2023
dougbu:dougbu/formatting.renames
Merged
Rename Formatting projects and more#392dougbu merged 4 commits intoaspnet:mainfrom dougbu:dougbu/formatting.renames
dougbu merged 4 commits intoaspnet:mainfrom
dougbu:dougbu/formatting.renames
Conversation
- Formatting.NetCore and Formatting.NetStandard names no longer make sense
- align w/ new project names
- `NETFX_CORE` name no longer makes much sense - remove both `NETFX_CORE` C# defined constant and `msbuild` property - manually-defined constant completely unnecessary in src/ code
- solution name no longer makes much sense and division adds little or no value - add .NET Standard projects to Runtime.sln - add solution filters for .NET Framework and .NET Standard projects - remove `$(BuildPortable)` property and `@(SolutionsToBuild)` item group
wtgodbe
approved these changes
Feb 27, 2023
Collaborator
wtgodbe
left a comment
There was a problem hiding this comment.
Changes seem reasonable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netstandardFormatting projectsnetstandardFormatting output pathsNETSTANDARD1_3andTesting_NetStandard1_3NETFX_COREname no longer makes much senseNETFX_COREC# defined constant andmsbuildproperty$(BuildPortable)property and@(SolutionsToBuild)item group