Skip to content

refactor: upgrade aspect_bazel_lib,rules_nodejs for bazel9 fixes#2659

Merged
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:2459-bazel9
Jan 18, 2026
Merged

refactor: upgrade aspect_bazel_lib,rules_nodejs for bazel9 fixes#2659
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:2459-bazel9

Conversation

@jbedard
Copy link
Copy Markdown
Member

@jbedard jbedard commented Jan 17, 2026

This is already done in the 3.x branch but seem minor enough to include in 2.x.

Close #2459

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Jan 17, 2026

Bazel 7 (Test)

All tests were cache hits

314 tests (100.0%) were fully cached saving 42s.


Bazel 8 (Test)

All tests were cache hits

277 tests (100.0%) were fully cached saving 44s.


Bazel 7 (Test)

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 599ms.


Bazel 7 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 23ms.


Bazel 7 (Test)

e2e/git_dep_no_tar

All tests were cache hits

1 test (100.0%) was fully cached saving 24ms.


Bazel 7 (Test)

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 203ms.


Bazel 7 (Test)

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.


Bazel 7 (Test)

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 274ms.


Bazel 7 (Test)

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 353ms.


Bazel 7 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 279ms.


Bazel 7 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 1s.


Bazel 7 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

3 tests (100.0%) were fully cached saving 259ms.


Bazel 7 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 122ms.


Bazel 7 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 34ms.


Bazel 7 (Test)

e2e/npm_translate_lock_link_workspace

All tests were cache hits

2 tests (100.0%) were fully cached saving 194ms.


Bazel 7 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.


Bazel 7 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.


Bazel 7 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 624ms.


Bazel 7 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 95ms.


Bazel 7 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 278ms.


Bazel 7 (Test)

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/pnpm_lockfiles

All tests were cache hits

82 tests (100.0%) were fully cached saving 10s.


Bazel 7 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 1s.


Bazel 7 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 133ms.


Bazel 7 (Test)

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.


Bazel 7 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 402ms.


Bazel 7 (Test)

e2e/pnpm_workspace_rerooted

7 test targets passed

Targets
//:node_test [k8-fastbuild]296ms
//app/a:aspect_test_a_bin_test [k8-fastbuild]245ms
//app/a:test [k8-fastbuild]205ms
//app/b:test [k8-fastbuild]203ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]464ms
//app/c:test [k8-fastbuild]214ms
//app/d:test [k8-fastbuild]394ms

Total test execution time was 2s. 8 tests (53.3%) were fully cached saving 714ms.


Bazel 7 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 411ms.


Bazel 7 (Test)

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 113ms.


Bazel 7 (Test)

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.


Bazel 7 (Test)

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 103ms.


Bazel 7 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 109ms.


Bazel 7 (Test)

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.


Bazel 7 (Test)

e2e/workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.


Buildifier      Format

@jbedard jbedard force-pushed the 2459-bazel9 branch 3 times, most recently from 4fa039f to 33314d4 Compare January 17, 2026 07:16
@jbedard jbedard changed the title chore: enable bazel9 rc tests (#2648) refactor: upgrade aspect_bazel_lib,rules_nodejs for bazel9 fixes Jan 17, 2026
@jbedard jbedard requested a review from alexeagle January 17, 2026 07:23
@jbedard jbedard marked this pull request as ready for review January 17, 2026 07:23
@jbedard jbedard merged commit 74d32f8 into aspect-build:main Jan 18, 2026
113 checks passed
@jbedard jbedard deleted the 2459-bazel9 branch January 18, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: rules_nodejs and aspect_bazel_lib dependencies need to be updated to Bazel 9-compatible version

1 participant