Skip to content

refactor: simplify generated npm_link_targets implementations#2424

Merged
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:npm_link-less
Nov 6, 2025
Merged

refactor: simplify generated npm_link_targets implementations#2424
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:npm_link-less

Conversation

@jbedard
Copy link
Copy Markdown
Member

@jbedard jbedard commented Nov 6, 2025

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from Mivr November 6, 2025 01:41
@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Nov 6, 2025

Test

3 test targets passed

Targets
//npm/private/test:write_npm_translate_lock_0_test [k8-fastbuild] 144ms
//npm/private:_test_gendocs_0_0 [k8-fastbuild]                    72ms
//npm/private:_test_gendocs_0_1 [k8-fastbuild]                    43ms

Total test execution time was 259ms. 291 tests (99.0%) were fully cached saving 48s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 562ms.


Test

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 184ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 664ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 596ms.


Test

e2e/npm_link_package-rerooted

All tests were cache hits

3 tests (100.0%) were fully cached saving 564ms.


Test

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 582ms.


Test

e2e/npm_translate_lock_disable_hooks

1 test target passed

Targets
//:write_npm_translate_lock_defs_0_test [k8-fastbuild]            94ms

Total test execution time was 94ms. 2 tests (66.7%) were fully cached saving 147ms.


Test

e2e/npm_translate_lock_empty

1 test target passed

Targets
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]            74ms

Total test execution time was 74ms. 1 test (50.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 34ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 413ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 105ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 313ms.


Test

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/pnpm_lockfiles

5 test targets passed

Targets
//v101:repos_0_test [k8-fastbuild]                                130ms
//v54:repos_0_test [k8-fastbuild]                                 98ms
//v60:repos_0_test [k8-fastbuild]                                 137ms
//v61:repos_0_test [k8-fastbuild]                                 139ms
//v90:repos_0_test [k8-fastbuild]                                 145ms

Total test execution time was 649ms. 62 tests (92.5%) were fully cached saving 7s.


Test

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 950ms.


Test

e2e/pnpm_workspace

1 test target passed

Targets
//:repos_test [k8-fastbuild]                                      91ms

Total test execution time was 91ms. 14 tests (93.3%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 703ms.


Test

e2e/pnpm_workspace_rerooted

1 test target passed

Targets
//:repos_test [k8-fastbuild]                                      108ms

Total test execution time was 108ms. 14 tests (93.3%) were fully cached saving 4s.


Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 454ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 189ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 118ms.


Test

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 78ms.


Test

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 109ms.


Test

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.


Test

e2e/workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.


Buildifier      Format

@jbedard jbedard merged commit 0b0e242 into aspect-build:main Nov 6, 2025
102 checks passed
@jbedard jbedard deleted the npm_link-less branch November 6, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants