Skip to content

test: upgrade e2e/npm_translate_lock_empty to pnpm 9#2414

Merged
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:empty-pnpm9
Nov 4, 2025
Merged

test: upgrade e2e/npm_translate_lock_empty to pnpm 9#2414
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:empty-pnpm9

Conversation

@jbedard
Copy link
Copy Markdown
Member

@jbedard jbedard commented Nov 2, 2025 •
edited
Loading

This test highlights the bugs with the dev: #2013

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard changed the title fix: pnpm 9+ exclusion of devonly deps WIP: fix: pnpm 9+ exclusion of devonly deps Nov 2, 2025
@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Nov 2, 2025 •
edited
Loading

Test

All tests were cache hits

293 tests (100.0%) were fully cached saving 48s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 640ms.

Test

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 173ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 407ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 484ms.

Test

e2e/npm_link_package-rerooted

All tests were cache hits

3 tests (100.0%) were fully cached saving 536ms.

Test

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 919ms.

Test

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

3 tests (100.0%) were fully cached saving 247ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 107ms.

Test

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 34ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 384ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 95ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 348ms.

Test

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

67 tests (100.0%) were fully cached saving 9s.

Test

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 950ms.

Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 901ms.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 5s.

Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 454ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 258ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 118ms.

Test

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 78ms.

Test

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 109ms.

Test

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.

Test

e2e/workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.

Buildifier      Format

@jbedard jbedard changed the title WIP: fix: pnpm 9+ exclusion of devonly deps test: upgrade e2e/npm_translate_lock_empty to pnpm 9 Nov 4, 2025
@jbedard jbedard requested review from Mivr and dzbarsky November 4, 2025 08:28
@jbedard jbedard marked this pull request as ready for review November 4, 2025 08:29
jbedard
jbedard commented Nov 4, 2025
View reviewed changes
Comment thread e2e/npm_translate_lock_empty/WORKSPACE

load("@@npm//:repositories.bzl", "npm_repositories")

npm_repositories()
Copy link
Copy Markdown
Member Author

@jbedard jbedard Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the dev flag is gone this setup call is actually required, otherwise the npm__debug__4.4.3__links repos won't be created at all.

@jbedard jbedard merged commit 5fa9338 into aspect-build:main Nov 4, 2025
101 of 102 checks passed
@jbedard jbedard deleted the empty-pnpm9 branch November 4, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzbarsky dzbarsky dzbarsky approved these changes

@Mivr Mivr Awaiting requested review from Mivr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbedard @dzbarsky