Skip to content

refactor: move AspectWatchProtocol to standalone library#2374

Merged
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:watch-protocol
Oct 6, 2025
Merged

refactor: move AspectWatchProtocol to standalone library#2374
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:watch-protocol

Conversation

@jbedard
Copy link
Copy Markdown
Member

@jbedard jbedard commented Oct 3, 2025 •
edited
Loading

For some experimental importing+usage of this class in binaries supporting the watch protocol. The goal is minimizing actual changes within rules_js so for now the js_run_devserver.mjs is bundled and is almost identical to before.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Oct 3, 2025 •
edited
Loading

Test

All tests were cache hits

228 tests (100.0%) were fully cached saving 31s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 621ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 200ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 5s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 605ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 479ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 387ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 114ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 496ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

67 tests (100.0%) were fully cached saving 10s.

Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 4s.

Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 466ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 246ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 111ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 118ms.

Buildifier      Format

@jbedard jbedard force-pushed the watch-protocol branch 6 times, most recently from 176cc1c to 3219992 Compare October 3, 2025 05:42
@jbedard jbedard force-pushed the watch-protocol branch 2 times, most recently from 95ab2ff to 9716759 Compare October 3, 2025 07:06
@jbedard jbedard requested a review from gregmagolan October 3, 2025 08:06
nickschaap
nickschaap reviewed Oct 3, 2025
View reviewed changes
Comment thread js/private/src/rollup.config.mjs Outdated
nickschaap
nickschaap reviewed Oct 3, 2025
View reviewed changes
Comment thread js/private/js_run_devserver.mjs
nickschaap
nickschaap reviewed Oct 3, 2025
View reviewed changes
Comment thread js/private/devserver/src/package.json
nickschaap
nickschaap reviewed Oct 3, 2025
View reviewed changes
Comment thread js/private/src/aspect_watch_protocol.d.mts Outdated
@jbedard jbedard force-pushed the watch-protocol branch 3 times, most recently from 6d014cc to a9aad04 Compare October 3, 2025 17:26
@jbedard jbedard requested a review from alexeagle October 3, 2025 17:29
@jbedard jbedard marked this pull request as ready for review October 4, 2025 02:23
@jbedard jbedard requested a review from dzbarsky October 6, 2025 20:11
@dzbarsky
Copy link
Copy Markdown
Collaborator

dzbarsky commented Oct 6, 2025

@codex please review this

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Oct 6, 2025

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@jbedard jbedard merged commit c0659cd into aspect-build:main Oct 6, 2025
98 of 99 checks passed
@jbedard jbedard deleted the watch-protocol branch October 6, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thesayyn thesayyn thesayyn approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

@alexeagle alexeagle Awaiting requested review from alexeagle

@dzbarsky dzbarsky Awaiting requested review from dzbarsky

+1 more reviewer

@nickschaap nickschaap nickschaap left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbedard @dzbarsky @nickschaap @thesayyn