Skip to content

feat: add replace_package module extension tag#2289

Merged
jbedard merged 19 commits intoaspect-build:mainfrom
SimpleSoftwareOrg:replace-packages-extension
Oct 29, 2025
Merged

feat: add replace_package module extension tag#2289
jbedard merged 19 commits intoaspect-build:mainfrom
SimpleSoftwareOrg:replace-packages-extension

Conversation

@Mivr
Copy link
Copy Markdown
Collaborator

@Mivr Mivr commented Jul 28, 2025

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): yes
  • Suggested release notes appear below: yes

feat: moved replace package to a tag class for bzlmod

Test plan

  • Updated old test case

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Jul 28, 2025 •
edited
Loading

Test

All tests were cache hits

278 tests (100.0%) were fully cached saving 37s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 618ms.

Test

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 173ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 407ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 484ms.

Test

e2e/npm_link_package-rerooted

All tests were cache hits

3 tests (100.0%) were fully cached saving 536ms.

Test

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 919ms.

Test

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

3 tests (100.0%) were fully cached saving 247ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 34ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.

Test

e2e/npm_translate_lock_replace_packages

1 test target passed

Targets 
//:test [k8-fastbuild]86ms

Total test execution time was 86ms. 3 tests (75.0%) were fully cached saving 298ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 95ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 348ms.

Test

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

67 tests (100.0%) were fully cached saving 9s.

Test

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 2s.

Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 901ms.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 5s.

Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 454ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 258ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 118ms.

Test

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 78ms.

Test

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 109ms.

Test

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.

Test

e2e/workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.

Buildifier      Format

jbedard
jbedard reviewed Jul 28, 2025
View reviewed changes
Comment thread npm/extensions.bzl Outdated
jbedard
jbedard reviewed Jul 28, 2025
View reviewed changes
Comment thread npm/extensions.bzl Outdated
@Mivr Mivr marked this pull request as ready for review August 5, 2025 17:59
jbedard
jbedard reviewed Aug 5, 2025
View reviewed changes
Comment thread npm/private/npm_translate_lock.bzl
jbedard
jbedard reviewed Aug 5, 2025
View reviewed changes
Comment thread npm/extensions.bzl Outdated
jbedard
jbedard reviewed Aug 6, 2025
View reviewed changes
Comment thread npm/extensions.bzl Outdated
@simoViso simoViso deleted the replace-packages-extension branch August 7, 2025 15:10
@Mivr Mivr restored the replace-packages-extension branch August 11, 2025 12:18
jbedard
jbedard reviewed Aug 11, 2025
View reviewed changes
Comment thread e2e/npm_translate_lock_replace_packages/utils_module/MODULE.bazel
jbedard
jbedard reviewed Aug 13, 2025
View reviewed changes
Comment thread e2e/npm_translate_lock_replace_packages/utils_module/test.mjs Outdated
jbedard
jbedard reviewed Aug 13, 2025
View reviewed changes
Comment thread e2e/npm_translate_lock_replace_packages/.bazelignore
@Mivr Mivr force-pushed the replace-packages-extension branch from f1bc621 to ee5b4e4 Compare October 14, 2025 13:09
jbedard
jbedard reviewed Oct 14, 2025
View reviewed changes
Comment thread e2e/npm_translate_lock_replace_packages/utils_module/MODULE.bazel Outdated
jbedard
jbedard reviewed Oct 14, 2025
View reviewed changes
Comment thread e2e/npm_translate_lock_replace_packages/utils_module/MODULE.bazel Outdated
jbedard
jbedard reviewed Oct 14, 2025
View reviewed changes
Comment thread npm/extensions.bzl Outdated
jbedard
jbedard reviewed Oct 14, 2025
View reviewed changes
Comment thread npm/extensions.bzl Outdated
jbedard
jbedard reviewed Oct 14, 2025
View reviewed changes
Comment thread npm/extensions.bzl Outdated
@Mivr Mivr force-pushed the replace-packages-extension branch from e2386a1 to df6f595 Compare October 24, 2025 06:30
jbedard
jbedard reviewed Oct 24, 2025
View reviewed changes
Comment thread e2e/npm_translate_lock_replace_packages/main.js Outdated
jbedard
jbedard reviewed Oct 24, 2025
View reviewed changes
Comment thread npm/extensions.bzl
@jbedard jbedard changed the title Add replace_package module extension tag feat: add replace_package module extension tag Oct 29, 2025
@jbedard jbedard merged commit d407a2e into aspect-build:main Oct 29, 2025
99 checks passed
@Mivr Mivr deleted the replace-packages-extension branch October 30, 2025 17:36
@jbedard jbedard mentioned this pull request Nov 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedard jbedard jbedard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mivr @CLAassistant @jbedard @simoViso