Skip to content

fix: npm_translate_lock(exclude_package_contents["*"]) should only be a fallback if no explicit package found#2151

Merged
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:package-excludes-exclusive
Apr 3, 2025
Merged

fix: npm_translate_lock(exclude_package_contents["*"]) should only be a fallback if no explicit package found#2151
jbedard merged 1 commit intoaspect-build:mainfrom
jbedard:package-excludes-exclusive

Conversation

@jbedard
Copy link
Copy Markdown
Member

@jbedard jbedard commented Apr 2, 2025

This allows overriding the default to not exclude anything such as:

exclude_package_contents = {
    "next": [],
}

Changes are visible to end-users: no

Test plan

  • Manual testing; used the default list on a repo using nextjs which depends on a /images/ directory.

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Apr 2, 2025 •
edited
Loading

Test

All tests were cache hits

236 tests (100.0%) were fully cached saving 33s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 502ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 169ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 2s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 448ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 533ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 603ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 98ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 253ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

42 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 404ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 187ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 173ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 99ms.

Buildifier      Format

@jbedard jbedard force-pushed the package-excludes-exclusive branch from 716717a to 5b7c58f Compare April 2, 2025 02:14
@jbedard jbedard merged commit a2f3fff into aspect-build:main Apr 3, 2025
98 checks passed
@jbedard jbedard deleted the package-excludes-exclusive branch April 3, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexeagle alexeagle alexeagle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbedard @alexeagle