Fix memory allocations counters on macOS.#2673
Merged
Lukasa merged 1 commit intoapple:mainfrom Mar 6, 2024
Merged
Conversation
Motivation: Allocation counters are broken on macOS as described [here](apple#2672). This PR fixes it. Modifications: `AtomicCounter` library is made `.dynamic`. This deduplicates the two (static) copies that used to exist. One embedded in the main binary, and the other in `HookedFunctions` dylib. This deplication fixes the issue, because there is just one copy of the counters in the process address space. Result: All the tests counting allocations and related statistics work on macOS.
Lukasa
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Allocation counters are broken on macOS as described here: #2672. This PR fixes it.
Modifications
AtomicCounterlibrary is made.dynamic. This deduplicates the two (static) copies that used to exist. One embedded in the main binary, and the other inHookedFunctionsdylib. This deplication fixes the issue, because there is just one copy of the counters in the process address space.Result
All the tests counting allocations and related statistics work on macOS.