Remove @unchecked Sendable conformance from ChannelOptions.Storage#2638
Merged
glbrntt merged 3 commits intoapple:mainfrom Feb 12, 2024
Merged
Remove @unchecked Sendable conformance from ChannelOptions.Storage#2638glbrntt merged 3 commits intoapple:mainfrom
@unchecked Sendable conformance from ChannelOptions.Storage#2638glbrntt merged 3 commits intoapple:mainfrom
Conversation
Lukasa
approved these changes
Feb 1, 2024
Member
Author
|
Breaking change is a false positive:
|
Member
Author
|
@swift-server-bot test this please |
# Motivation We currently have an unchecked `Sendable` conformance on `ChannelOptions.Storage` which is not necessary and in fact we are missing a proper `Sendable` requirement on the `ChannelOption.Value` protocol right now. # Modification This PR adds the `Sendable` requirement on the `ChannelOption.Value` and replaces the unchecked conformance on the storage with a regular one. # Result No more `Sendable` warnings in strict concurrency mode inside `ChannelOptions`.
cdd77e9 to
010e6f3
Compare
5bcd73c to
31457e6
Compare
Member
Author
|
@swift-server-bot test this please |
ae61486 to
9fc8804
Compare
9fc8804 to
72ae400
Compare
Member
Author
|
The breaking change is expected as above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We currently have an unchecked
Sendableconformance onChannelOptions.Storagewhich is not necessary and in fact we are missing a properSendablerequirement on theChannelOption.Valueprotocol right now.Modification
This PR adds the
Sendablerequirement on theChannelOption.Valueand replaces the unchecked conformance on the storage with a regular one.Result
No more
Sendablewarnings in strict concurrency mode insideChannelOptions.