Remove NIOProtocolNegotiationResult#2554
Merged
Lukasa merged 1 commit intoapple:mainfrom Oct 16, 2023
Merged
Conversation
Lukasa
approved these changes
Oct 16, 2023
glbrntt
approved these changes
Oct 16, 2023
# Motivation After playing around more with the new async bootstrap methods, I came to the conclusion that the `NIOProtocolNegotiationResult` isn't carrying its weight. The `NIOProtocolNegotiationResult` is a glorified `EventLoopFuture` with an easy way to recursively resolve nested futures. Furthermore, it forces any nested protocol negotiation to use the same generic type for the end result. # Modification This PR removes the `NIOProtocolNegotiationResult` and changes all the tests to be solely based on `EventLoopFuture`s. # Result Less code to support the async bootstrap and better composition of nested protocol negotiation handlers.
9575062 to
c0abb3f
Compare
Member
Author
|
API breakage is expected. @Lukasa do you mind merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After playing around more with the new async bootstrap methods, I came to the conclusion that the
NIOProtocolNegotiationResultisn't carrying its weight. TheNIOProtocolNegotiationResultis a glorifiedEventLoopFuturewith an easy way to recursively resolve nested futures. Furthermore, it forces any nested protocol negotiation to use the same generic type for the end result.Modification
This PR removes the
NIOProtocolNegotiationResultand changes all the tests to be solely based onEventLoopFutures.Result
Less code to support the async bootstrap and better composition of nested protocol negotiation handlers.