Breaking SPI(AsyncChannel): Align back pressure naming#2527
Merged
Lukasa merged 2 commits intoapple:mainfrom Oct 3, 2023
Merged
Breaking SPI(AsyncChannel): Align back pressure naming#2527Lukasa merged 2 commits intoapple:mainfrom
Lukasa merged 2 commits intoapple:mainfrom
Conversation
# Motivation We spelled back pressure a few different ways throughout our async interfaces. # Modification This PR aligns to `backPressure` everywhere and uses `back pressure` in comments.
glbrntt
approved these changes
Oct 3, 2023
Member
Author
|
@swift-server-bot test this please |
Member
Author
|
API breakage is expected since we renamed the back pressure parameters. @Lukasa can you merge this for me please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We spelled back pressure a few different ways throughout our async interfaces.
Modification
This PR aligns to
backPressureeverywhere and usesback pressurein comments.