[SLG-0005]: LogEvent LogHandler API proposal#424
Merged
kukushechkin merged 4 commits intomainfrom Mar 20, 2026
Merged
Conversation
2cddf68 to
540321e
Compare
FranzBusch
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the flat-parameter
log(level:message:metadata:source:file:function:line:)method onLogHandlerwithlog(event: LogEvent), enabling forward-compatible evolution of theLogHandlerinterface without breaking existinghandler implementations.
Motivation:
Changes to the
LogHandlerAPI require dance around creating new overloads, deprecating old overloads, which unnecessary bloatsLogHandlerprotocol surface (like happened with the source: parameter). We have upcoming changes that would introduce new capabilities to theLogHandlerprotocol, for example https://forums.swift.org/t/proposal-slg-0003-standardized-error-metadata-via-logger-convenience/84518/35. It makes sense to introduce a single container structure for all the data associated with a log event before introducing any new overloads inLogHandlerprotocol.Modifications:
Result:
Proposal is ready for implementation.
The reason the proposal has