ArgumentParser: make invalid cast explicit#913
Merged
Conversation
The error codes on Windows are unsigned (and do make use of the sign bit). We explicitly treat the values as signed, so make the conversion explicit. This is required with future enhancements to enable canonical importing of constants on Windows.
rauhul
approved these changes
May 31, 2026
Member
|
@compnerd Is this issue something that is catchable in testing? |
Collaborator
Author
|
@natecook1000 sadly not - its an API shape thing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error codes on Windows are unsigned (and do make use of the sign bit). We explicitly treat the values as signed, so make the conversion explicit. This is required with future enhancements to enable canonical importing of constants on Windows.