Fixed nil dependency panic in Ruby Gemfile.lock resolver#207
Merged
kezhenxu94 merged 1 commit intoapache:mainfrom Sep 13, 2025
Merged
Fixed nil dependency panic in Ruby Gemfile.lock resolver#207kezhenxu94 merged 1 commit intoapache:mainfrom
kezhenxu94 merged 1 commit intoapache:mainfrom
Conversation
…olver - now treats missing specs as unresolved licenses - adds them to the invalid list - License fetch logic handles empty gem versions gracefully - tests updated - handle missing specs gracefully with mocked HTTP responses - imports and packages were refactored to enable mocking and improve test structure
Contributor
Author
|
@wu-sheng @kezhenxu94 I think this may be sufficient. I don't see any other changes needed. ... well aside from the issue of it checking development dependencies for a library. That's not supposed to happen. Going to write more tests to see if I can reproduce that. I can make that a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.