Skip to content

Bump up to go 1.23 and clean up Docker images#188

Merged
wu-sheng merged 1 commit intomainfrom
docker
Feb 8, 2025
Merged

Bump up to go 1.23 and clean up Docker images#188
wu-sheng merged 1 commit intomainfrom
docker

Conversation

@kezhenxu94
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 commented Feb 8, 2025

Dependencies license check depends on different programming language env and version, it’s unreasonable to include the env in the Docker image by default, this PR cleans the programming language tools from the Docker images to reduce the size from 350+M to ~36M

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Feb 8, 2025

from 350+M to?

@kezhenxu94
Copy link
Copy Markdown
Member Author

from 350+M to?

Updated the description

@kezhenxu94 kezhenxu94 added this to the 0.7.0 milestone Feb 8, 2025
# specific language governing permissions and limitations
# under the License.

FROM apache/skywalking-eyes:latest
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we push version:latest-go-deps image as well to make it convenient?

Copy link
Copy Markdown
Member Author

@kezhenxu94 kezhenxu94 Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we push version:latest-go-deps image as well to make it convenient?

I'm not sure whether it'll be convenient, people might be using different go version and it does not make things much better unless we want to push tens of tags for each Go version

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Feb 8, 2025

350+M to ~36M It seems this is worth a new release. Just wonder whether #188 (comment) is worth.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Feb 8, 2025

Meanwhile, for our own user case, the main repo seems to require Java and Node to do dependency analysis, right? How are we going to support that?

@kezhenxu94
Copy link
Copy Markdown
Member Author

Meanwhile, for our own user case, the main repo seems to require Java and Node to do dependency analysis, right? How are we going to support that?

Simple. We are not using Docker to do that, we use the binary executable right in the system

@kezhenxu94
Copy link
Copy Markdown
Member Author

People who want to use dependencies check with Docker in their projects , they need to build their docker image based on the license-eye docker image, that would be a case by case scenario, some might need to install all of Go 1.19, Java, and npm, some might just need Go 1.23, I'm not going to release an image that contains these various tools.

@wu-sheng wu-sheng merged commit 966951c into main Feb 8, 2025
1 check passed
@wu-sheng wu-sheng deleted the docker branch February 8, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants