Skip to content

[fix][broker] Fix potential deadlock when creating partitioned topic #24313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liangyepianzhou merged 3 commits into from
May 19, 2025
Merged

[fix][broker] Fix potential deadlock when creating partitioned topic #24313

liangyepianzhou merged 3 commits into from
May 19, 2025
+34 −19

Conversation

@nodece
Copy link
Member

@nodece nodece commented May 16, 2025 •
edited
Loading

Motivation

There is still a call to the synchronous method in internalCreatePartitionedTopic, which can lead to a deadlock under certain conditions.

Modifications

  • Replaced synchronous call to getNamespacePolicies() with getNamespacePoliciesAsync().
  • Replaced synchronous call to getTopicPartitionList() with getTopicPartitionListAsync().
  • Updated internalCreatePartitionedTopic to propagate the async flow properly.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 16, 2025
@nodece
[fix][broker] Fix potential deadlock when creating partitioned topic
adc0a37 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece force-pushed the fix-internalCreatePartitionedTopic-deadlock branch from 480fded to adc0a37 Compare May 16, 2025 10:45
@nodece
Use pattern variable
6a78307 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece requested a review from lhotari May 16, 2025 13:28
@nodece nodece closed this May 16, 2025
@nodece nodece reopened this May 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (bbc6224) to head (bbb4567).
Report is 1104 commits behind head on master.

Files with missing lines Patch % Lines
.../org/apache/pulsar/broker/admin/AdminResource.java 83.33% 1 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24313      +/-   ##
============================================
+ Coverage     73.57%   74.25%   +0.68%     
+ Complexity    32624    32260     -364     
============================================
  Files          1877     1866      -11     
  Lines        139502   145103    +5601     
  Branches      15299    16591    +1292     
============================================
+ Hits         102638   107753    +5115     
+ Misses        28908    28827      -81     
- Partials       7956     8523     +567
Flag Coverage Δ
inttests 26.65% <16.66%> (+2.07%) ⬆️
systests 23.24% <16.66%> (-1.08%) ⬇️
unittests 73.75% <83.33%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../org/apache/pulsar/broker/admin/AdminResource.java 75.76% <83.33%> (-1.86%) ⬇️

... and 1085 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liangyepianzhou liangyepianzhou added this to the 4.1.0 milestone May 19, 2025
@nodece
Address comment
bbb4567 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@liangyepianzhou liangyepianzhou merged commit 7ca8c0e into apache:master May 19, 2025
53 checks passed
lhotari pushed a commit that referenced this pull request May 20, 2025
@nodece @lhotari
[fix][broker] Fix potential deadlock when creating partitioned topic (#…
76e5479 
…24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.

(cherry picked from commit 7ca8c0e)
lhotari pushed a commit that referenced this pull request May 20, 2025
@nodece @lhotari
[fix][broker] Fix potential deadlock when creating partitioned topic (#…
f7708dc 
…24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.

(cherry picked from commit 7ca8c0e)
lhotari pushed a commit that referenced this pull request May 20, 2025
@nodece @lhotari
[fix][broker] Fix potential deadlock when creating partitioned topic (#…
bdf41aa 
…24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.

(cherry picked from commit 7ca8c0e)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 28, 2025
@nodece @manas-ctds
[fix][broker] Fix potential deadlock when creating partitioned topic (a…
5797345 
…pache#24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.

(cherry picked from commit 7ca8c0e)
(cherry picked from commit 76e5479)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 28, 2025
@nodece @ganesh-ctds
[fix][broker] Fix potential deadlock when creating partitioned topic (a…
60301b0 
…pache#24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.

(cherry picked from commit 7ca8c0e)
(cherry picked from commit bdf41aa)
nodece added a commit to ascentstream/pulsar that referenced this pull request May 28, 2025
@nodece
[fix][broker] Fix potential deadlock when creating partitioned topic (a…
7960227 
…pache#24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.

(cherry picked from commit 7ca8c0e)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 29, 2025
@nodece @srinath-ctds
[fix][broker] Fix potential deadlock when creating partitioned topic (a…
919f62b 
…pache#24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.

(cherry picked from commit 7ca8c0e)
(cherry picked from commit 76e5479)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 2, 2025
@nodece @srinath-ctds
[fix][broker] Fix potential deadlock when creating partitioned topic (a…
2876722 
…pache#24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.

(cherry picked from commit 7ca8c0e)
(cherry picked from commit bdf41aa)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
@nodece @KannarFr
[fix][broker] Fix potential deadlock when creating partitioned topic (a…
58d6715 
…pache#24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@nodece @walkinggo
[fix][broker] Fix potential deadlock when creating partitioned topic (a…
a4b0696 
…pache#24313)

### Motivation

There is still a call to the synchronous method in `internalCreatePartitionedTopic`, which can lead to a deadlock under certain conditions.

### Modifications

- Replaced synchronous call to `getNamespacePolicies()` with `getNamespacePoliciesAsync()`.
- Replaced synchronous call to `getTopicPartitionList()` with `getTopicPartitionListAsync()`.
- Updated `internalCreatePartitionedTopic` to propagate the async flow properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@liangyepianzhou liangyepianzhou liangyepianzhou approved these changes

@dao-jun dao-jun Awaiting requested review from dao-jun

@liudezhi2098 liudezhi2098 Awaiting requested review from liudezhi2098

Assignees

@nodece nodece

Labels

cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.12 release/3.3.7 release/4.0.5

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nodece @codecov-commenter @lhotari @liangyepianzhou