[improve][io] Add configuration parameter for disabling aggregation for Kinesis Producers #24289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rds into single kinesis record
lhotari
reviewed
May 12, 2025
pulsar-io/kinesis/src/main/java/org/apache/pulsar/io/kinesis/KinesisSinkConfig.java
Outdated
Show resolved
Hide resolved
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…or Kinesis Producers (apache#24289) (cherry picked from commit 18438bb)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
…or Kinesis Producers (apache#24289) (cherry picked from commit 18438bb)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
…or Kinesis Producers (apache#24289) (cherry picked from commit 18438bb)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
…or Kinesis Producers (apache#24289) (cherry picked from commit 18438bb)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
…or Kinesis Producers (apache#24289) (cherry picked from commit 18438bb)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 28, 2025
…or Kinesis Producers (apache#24289) (cherry picked from commit 18438bb) (cherry picked from commit 57c4b9b)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
…or Kinesis Producers (apache#24289) (cherry picked from commit 18438bb)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 2, 2025
…or Kinesis Producers (apache#24289) (cherry picked from commit 18438bb) (cherry picked from commit 57c4b9b)
15 tasks
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…or Kinesis Producers (apache#24289)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…or Kinesis Producers (apache#24289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24288
Motivation
The Kinesis Sink currently always enables aggregation of records while producing to the kinesis data streams. This results in records being merged in the final output described awslabs/amazon-kinesis-producer#566. There are use cases like monitoring logs through streams UI and client applications expecting certain record type where this behaviour is not desirable.
Modifications
Added an
enableAggregationoption toKinesisSinkConfigand updatedKinesisSink#openso that it reads this flag when constructing the Kinesis producer.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
cognitree#21