Skip to content

[fix][broker] Fix NPE from the wrong iterator in the ownership cleanup job(ExtensibleLoadManagerImpl only) #24196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heesung-sohn merged 1 commit into from
Apr 22, 2025
Merged

[fix][broker] Fix NPE from the wrong iterator in the ownership cleanup job(ExtensibleLoadManagerImpl only) #24196

heesung-sohn merged 1 commit into from
Apr 22, 2025

Conversation

@heesung-sohn
Copy link
Contributor

@heesung-sohn heesung-sohn commented Apr 22, 2025 •
edited by codelipenghui
Loading

Motivation

There was a bug from this PR, #24156 that causes NPE during the ownership clean-up, when overriding orphan system bundle ownerships.

Modifications

  • fix the wrong iterator.next()

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

github-actions bot commented Apr 22, 2025

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@heesung-sohn heesung-sohn self-assigned this Apr 22, 2025
@codelipenghui codelipenghui added type/bug The PR fixed a bug or issue reported a bug release/4.0.5 ready-to-test and removed doc-label-missing labels Apr 22, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 22, 2025
@codelipenghui codelipenghui reopened this Apr 22, 2025
@heesung-sohn heesung-sohn mentioned this pull request Apr 22, 2025
Merged
15 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (bbc6224) to head (9c81058).
Report is 1031 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24196      +/-   ##
============================================
+ Coverage     73.57%   74.16%   +0.59%     
+ Complexity    32624    32494     -130     
============================================
  Files          1877     1865      -12     
  Lines        139502   144653    +5151     
  Branches      15299    16523    +1224     
============================================
+ Hits         102638   107285    +4647     
+ Misses        28908    28872      -36     
- Partials       7956     8496     +540
Flag Coverage Δ
inttests 26.57% <0.00%> (+1.98%) ⬆️
systests 23.25% <0.00%> (-1.07%) ⬇️
unittests 73.64% <100.00%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...xtensions/channel/ServiceUnitStateChannelImpl.java 86.83% <100.00%> (+1.52%) ⬆️

... and 1070 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@heesung-sohn heesung-sohn merged commit 0a8c898 into apache:master Apr 22, 2025
73 of 81 checks passed
@heesung-sohn heesung-sohn deleted the fix-system-topic-ownership branch April 22, 2025 19:37
heesung-sohn added a commit that referenced this pull request Apr 22, 2025
@heesung-sohn
[fix][broker] Fix NPE from the wrong iterator in the ownership cleanu…
d958353 
…p job(ExtensibleLoadManagerImpl only) (#24196)

(cherry picked from commit 0a8c898)
@heesung-sohn heesung-sohn added cherry-picked/branch-2.7 Archived: 2.7 is end of life cherry-picked/branch-4.0 and removed cherry-picked/branch-2.7 Archived: 2.7 is end of life labels Apr 22, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 2, 2025
@heesung-sohn @nikhil-ctds
[fix][broker] Fix NPE from the wrong iterator in the ownership cleanu…
84fa926 
…p job(ExtensibleLoadManagerImpl only) (apache#24196)

(cherry picked from commit 0a8c898)
(cherry picked from commit d958353)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 6, 2025
@heesung-sohn @srinath-ctds
[fix][broker] Fix NPE from the wrong iterator in the ownership cleanu…
062e2cb 
…p job(ExtensibleLoadManagerImpl only) (apache#24196)

(cherry picked from commit 0a8c898)
(cherry picked from commit d958353)
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@heesung-sohn @walkinggo
[fix][broker] Fix NPE from the wrong iterator in the ownership cleanu…
840bd3a 
…p job(ExtensibleLoadManagerImpl only) (apache#24196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@lhotari lhotari Awaiting requested review from lhotari

@Demogorgon314 Demogorgon314 Awaiting requested review from Demogorgon314

Assignees

@heesung-sohn heesung-sohn

Labels

cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/4.0.5 type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heesung-sohn @codecov-commenter @codelipenghui