Skip to content

[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadataEnabled leaves orphan topic policies and topic schemas #24150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhotari merged 6 commits into from
Apr 9, 2025
Merged

[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadataEnabled leaves orphan topic policies and topic schemas #24150

lhotari merged 6 commits into from
Apr 9, 2025

Conversation

@poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Apr 2, 2025 •
edited by lhotari
Loading

Motivation

  • Configure: brokerDeleteInactivePartitionedTopicMetadataEnabled=true
  • Issue 1: Pulsar leaves orphan topic policies and topic schemas after cleaning the partitioned topic. you can reproduce the issue with the new test testTopicGC
  • Issue 2:
    • Pulsar will lead an orphan schema and a topic-level policy if users are enabling bidirectional Geo-Replication with a global ZK, you can reproduce the issue by ReplicationTopicGcUsingGlobalZKTest
    • This feature will lead a consumption issue if you are enabling one-way Geo-Replication with a global ZK. You can reproduce the issue by ReplicationTopicGcUsingGlobalZKTest

Modifications

  • fix issue 1
  • add notes for issue 2

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added type/bug The PR fixed a bug or issue reported a bug release/3.0.12 release/3.3.7 release/4.0.5 labels Apr 2, 2025
@poorbarcode poorbarcode added this to the 4.1.0 milestone Apr 2, 2025
@poorbarcode poorbarcode self-assigned this Apr 2, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 2, 2025
@poorbarcode
Copy link
Contributor Author

poorbarcode commented Apr 3, 2025

/pulsarbot rerun-failure-checks

lhotari
lhotari reviewed Apr 3, 2025
View reviewed changes
@poorbarcode poorbarcode requested a review from lhotari April 3, 2025 09:51
@poorbarcode
Copy link
Contributor Author

poorbarcode commented Apr 3, 2025

/pulsarbot rerun-failure-checks

@poorbarcode poorbarcode requested a review from lhotari April 8, 2025 07:57
lhotari
lhotari approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.21%. Comparing base (bbc6224) to head (059b903).
Report is 1009 commits behind head on master.

Files with missing lines Patch % Lines
...sar/broker/service/persistent/PersistentTopic.java 40.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24150      +/-   ##
============================================
+ Coverage     73.57%   74.21%   +0.63%     
+ Complexity    32624    32104     -520     
============================================
  Files          1877     1864      -13     
  Lines        139502   144473    +4971     
  Branches      15299    16483    +1184     
============================================
+ Hits         102638   107216    +4578     
+ Misses        28908    28789     -119     
- Partials       7956     8468     +512
Flag Coverage Δ
inttests 26.80% <0.00%> (+2.22%) ⬆️
systests 23.19% <0.00%> (-1.13%) ⬇️
unittests 73.69% <40.00%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 98.16% <ø> (-1.23%) ⬇️
...sar/broker/service/persistent/PersistentTopic.java 80.08% <40.00%> (+1.62%) ⬆️

... and 1066 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 610b72e into apache:master Apr 9, 2025
52 checks passed
Technoboy- pushed a commit that referenced this pull request Apr 9, 2025
@poorbarcode @Technoboy-
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
a3c5feb 
…aEnabled leaves orphan topic policies and topic schemas (#24150)
Technoboy- pushed a commit that referenced this pull request Apr 14, 2025
@poorbarcode @Technoboy-
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
37fcaa1 
…aEnabled leaves orphan topic policies and topic schemas (#24150)
shibd added a commit that referenced this pull request Apr 14, 2025
@shibd
Fix compilation failed afting cherry-picked #24150
1a86087
poorbarcode added a commit to poorbarcode/pulsar that referenced this pull request Apr 15, 2025
@poorbarcode
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
25a0ee7 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 15, 2025
@poorbarcode @nikhil-ctds
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
a9942c8 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit a3c5feb)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 16, 2025
@poorbarcode @nikhil-ctds
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
f6ba6ad 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit a3c5feb)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 16, 2025
@poorbarcode @nikhil-ctds
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
a90ae10 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit a3c5feb)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 16, 2025
@poorbarcode @nikhil-ctds
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
60efd27 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit a3c5feb)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 16, 2025
@poorbarcode @srinath-ctds
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
d049244 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit a3c5feb)
lhotari pushed a commit that referenced this pull request Apr 17, 2025
@poorbarcode @lhotari
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
df02f0b 
…aEnabled leaves orphan topic policies and topic schemas (#24150)

(cherry picked from commit 610b72e)
nodece pushed a commit to nodece/pulsar that referenced this pull request Apr 22, 2025
@poorbarcode @nodece
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
489ba6e 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit 610b72e)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 24, 2025
@poorbarcode @ganesh-ctds
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
2c913dc 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit 610b72e)
(cherry picked from commit df02f0b)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 24, 2025
@poorbarcode @ganesh-ctds
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
0c5ed77 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit 610b72e)
(cherry picked from commit df02f0b)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 30, 2025
@poorbarcode @ganesh-ctds
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
41a5666 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit 610b72e)
(cherry picked from commit df02f0b)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 2, 2025
@poorbarcode @manas-ctds
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
f597fd4 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)

(cherry picked from commit 610b72e)
(cherry picked from commit df02f0b)
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@poorbarcode @walkinggo
[fix][broker] The feature brokerDeleteInactivePartitionedTopicMetadat…
55474e8 
…aEnabled leaves orphan topic policies and topic schemas (apache#24150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@congbobo184 congbobo184 congbobo184 approved these changes

Assignees

@poorbarcode poorbarcode

Labels

cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.12 release/3.3.7 release/4.0.5 type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@poorbarcode @codecov-commenter @lhotari @Technoboy- @codelipenghui @congbobo184