Skip to content

[fix] [broker] rename to changeMaxReadPositionCount#22656

Merged
dao-jun merged 3 commits into
apache:masterfrom
thetumbled:Fix_RenameChangeMaxReadPositionAndAddAbortTimes
May 8, 2024
Merged

[fix] [broker] rename to changeMaxReadPositionCount#22656
dao-jun merged 3 commits into
apache:masterfrom
thetumbled:Fix_RenameChangeMaxReadPositionAndAddAbortTimes

Conversation

@thetumbled

@thetumbled thetumbled commented May 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

Though changeMaxReadPositionAndAddAbortTimes is described as: increment when change the max read position or add a abort txn.
In inplementation, we only increment it when change the max read position.

Modifications

Rename changeMaxReadPositionAndAddAbortTimes to changeMaxReadPositionTimes.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions

github-actions Bot commented May 6, 2024

Copy link
Copy Markdown

@thetumbled Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions Bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels May 6, 2024
@thetumbled

thetumbled commented May 6, 2024

Copy link
Copy Markdown
Member Author

PTAL, thanks. @lhotari @congbobo184 @liangyepianzhou @poorbarcode

@dao-jun dao-jun added area/broker type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/transaction ready-to-test labels May 8, 2024
@dao-jun dao-jun added this to the 3.3.0 milestone May 8, 2024
@thetumbled thetumbled changed the title [fix] [broker] rename to changeMaxReadPositionTimes. [fix] [broker] rename to changeMaxReadPositionCount May 8, 2024
@lhotari lhotari requested review from Technoboy- and congbobo184 May 8, 2024 05:37
lhotari
lhotari approved these changes May 8, 2024
View reviewed changes

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@thetumbled

thetumbled commented May 8, 2024

Copy link
Copy Markdown
Member Author

/pulsarbot rerun-failure-checks

@codecov-commenter

codecov-commenter commented May 8, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.12%. Comparing base (bbc6224) to head (3e2e3a4).
⚠️ Report is 1255 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22656      +/-   ##
============================================
- Coverage     73.57%   73.12%   -0.45%     
+ Complexity    32624     2401   -30223     
============================================
  Files          1877     1887      +10     
  Lines        139502   141068    +1566     
  Branches      15299    15482     +183     
============================================
+ Hits         102638   103163     +525     
- Misses        28908    29925    +1017     
- Partials       7956     7980      +24
Flag Coverage Δ
inttests 27.33% <71.42%> (+2.74%) ⬆️
systests 24.61% <0.00%> (+0.28%) ⬆️
unittests 72.15% <100.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ransaction/buffer/impl/TopicTransactionBuffer.java 88.16% <100.00%> (+0.41%) ⬆️

... and 337 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dao-jun dao-jun merged commit 5ab0512 into apache:master May 8, 2024
@lhotari lhotari mentioned this pull request May 13, 2024
Closed
@lhotari lhotari mentioned this pull request May 14, 2024
Merged
15 tasks
lhotari pushed a commit that referenced this pull request May 14, 2024
@thetumbled @lhotari
[fix] [broker] rename to changeMaxReadPositionCount (#22656)
1cf6a72 
(cherry picked from commit 5ab0512)
lhotari pushed a commit that referenced this pull request May 14, 2024
@thetumbled @lhotari
[fix] [broker] rename to changeMaxReadPositionCount (#22656)
1e53635 
(cherry picked from commit 5ab0512)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2024
@thetumbled @nikhil-ctds
[fix] [broker] rename to changeMaxReadPositionCount (apache#22656)
b2ed011 
(cherry picked from commit 5ab0512)
(cherry picked from commit 1cf6a72)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2024
@thetumbled @srinath-ctds
[fix] [broker] rename to changeMaxReadPositionCount (apache#22656)
7042b52 
(cherry picked from commit 5ab0512)
(cherry picked from commit 1cf6a72)
Technoboy- pushed a commit that referenced this pull request Jun 6, 2024
@thetumbled @Technoboy-
[fix] [broker] rename to changeMaxReadPositionCount (#22656)
4a1779e
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@thetumbled @hanmz
[fix] [broker] rename to changeMaxReadPositionCount (apache#22656)
dfc8fd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@dao-jun dao-jun dao-jun approved these changes

@congbobo184 congbobo184 Awaiting requested review from congbobo184

Assignees

@thetumbled thetumbled

Labels

area/broker area/transaction cherry-picked/branch-3.0 cherry-picked/branch-3.2 cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.5 release/3.2.3 release/3.3.1 type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@thetumbled @codecov-commenter @lhotari @Technoboy- @dao-jun @coderzc