[fix][broker] Disable system topic message deduplication#22582
Merged
dao-jun merged 3 commits intoMay 8, 2024
Conversation
poorbarcode
approved these changes
Apr 25, 2024
shibd
approved these changes
Apr 25, 2024
coderzc
approved these changes
Apr 25, 2024
Technoboy-
approved these changes
Apr 25, 2024
Member
|
close reopen to trigger ci checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22582 +/- ##
============================================
- Coverage 73.57% 71.62% -1.95%
+ Complexity 32624 4849 -27775
============================================
Files 1877 1889 +12
Lines 139502 149548 +10046
Branches 15299 17591 +2292
============================================
+ Hits 102638 107117 +4479
- Misses 28908 33869 +4961
- Partials 7956 8562 +606
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
pushed a commit
that referenced
this pull request
May 8, 2024
lhotari
pushed a commit
that referenced
this pull request
May 14, 2024
(cherry picked from commit 5ff0fb9)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Disable deduplication on system topic to avoid recovering deduplication WAL (especially from offloaded topic). Because the system topic usually is a precondition to other topics. Therefore, we should pay attention to topic loading time.
Note: If the system topic loading timeout may cause dependent topics to fail to run.
Dependency diagram: normal topic --rely on--> system topic --rely on--> deduplication recover --may rely on--> (tiered storage)
Modifications
Topic#isDeduplicationEnabledto judge if we should enable deduplication.Topic#isDeduplicationEnabledto returnfalse.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete