Skip to content

[fix][broker] avoid offload system topic#22497

Merged
dao-jun merged 5 commits into
apache:masterfrom
mattisonchao:fix/offload_system_topic
May 8, 2024
Merged

[fix][broker] avoid offload system topic#22497
dao-jun merged 5 commits into
apache:masterfrom
mattisonchao:fix/offload_system_topic

Conversation

@mattisonchao

Copy link
Copy Markdown
Member

Motivation

Avoid setting broker internal system topics using off-loader because some of them are the preconditions of other topics. The slow replying log speed will cause a delay in all the topic loading.(timeout)

Modifications

  • Add a condition check for offload policies.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Avoid setting broker internal system topics using off-loader because some of them are the
preconditions of other topics. The slow replying log speed will cause a delay in all the
topic loading.(timeout)
@mattisonchao mattisonchao self-assigned this Apr 13, 2024
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Apr 13, 2024
@mattisonchao mattisonchao added category/reliability The function does not work properly in certain specific environments or failures. e.g. data lost area/broker labels Apr 13, 2024
@mattisonchao mattisonchao added this to the 3.3.0 milestone Apr 13, 2024
@mattisonchao mattisonchao reopened this Apr 13, 2024

@dao-jun dao-jun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerTestBase.java Outdated
@dao-jun

dao-jun commented Apr 29, 2024

Copy link
Copy Markdown
Member

@mattisonchao Why do we closed this PR?

@dao-jun

dao-jun commented Apr 29, 2024

Copy link
Copy Markdown
Member

discussed with @mattisonchao , reopen the PR

@dao-jun dao-jun reopened this Apr 29, 2024
@dao-jun dao-jun closed this May 8, 2024
@dao-jun dao-jun reopened this May 8, 2024
@codecov-commenter

codecov-commenter commented May 8, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.94%. Comparing base (bbc6224) to head (5ca0963).
Report is 236 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #22497       +/-   ##
=============================================
- Coverage     73.57%   41.94%   -31.63%     
+ Complexity    32624    15011    -17613     
=============================================
  Files          1877     1749      -128     
  Lines        139502   139850      +348     
  Branches      15299    16220      +921     
=============================================
- Hits         102638    58660    -43978     
- Misses        28908    73885    +44977     
+ Partials       7956     7305      -651     
Flag Coverage Δ
inttests 28.65% <100.00%> (+4.07%) ⬆️
systests 25.80% <100.00%> (+1.48%) ⬆️
unittests 37.66% <100.00%> (-35.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rg/apache/pulsar/broker/service/BrokerService.java 62.21% <100.00%> (-18.57%) ⬇️

... and 1437 files with indirect coverage changes

@dao-jun dao-jun merged commit 3114199 into apache:master May 8, 2024
Technoboy- pushed a commit that referenced this pull request May 8, 2024
Co-authored-by: 道君 <daojun@apache.org>
lhotari pushed a commit that referenced this pull request May 14, 2024
Co-authored-by: 道君 <daojun@apache.org>
(cherry picked from commit 3114199)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2024
Co-authored-by: 道君 <daojun@apache.org>
(cherry picked from commit 3114199)
(cherry picked from commit 20483f5)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2024
Co-authored-by: 道君 <daojun@apache.org>
(cherry picked from commit 3114199)
(cherry picked from commit 20483f5)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Co-authored-by: 道君 <daojun@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/broker category/reliability The function does not work properly in certain specific environments or failures. e.g. data lost cherry-picked/branch-3.0 cherry-picked/branch-3.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.5 release/3.2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants