Skip to content

[fix][broker] Fix message drop record in producer stat#22458

Merged
Technoboy- merged 2 commits into
apache:masterfrom
zhangqian321:fixMessageDropRecord
Apr 10, 2024
Merged

[fix][broker] Fix message drop record in producer stat#22458
Technoboy- merged 2 commits into
apache:masterfrom
zhangqian321:fixMessageDropRecord

Conversation

@zhangqian321

Copy link
Copy Markdown
Contributor

Motivation

msgDrop record message drop rate when non-persist message reached max concurrent-message limit in producer. 'valueRate' in msgDrop stands for message drop rate, and 'rate' stands for batch drop rate, and shoud get valueRate in publisherStats.

image

Modifications

get valueRate instead

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Apr 8, 2024
@zhangqian321 zhangqian321 changed the title Fix message drop record in producer stat [fix][broker] Fix message drop record in producer stat Apr 8, 2024

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari requested review from Technoboy- and asafm April 9, 2024 11:27
@lhotari lhotari requested a review from codelipenghui April 10, 2024 03:27
@Technoboy- Technoboy- added this to the 3.3.0 milestone Apr 10, 2024
@Technoboy- Technoboy- merged commit cea1a9b into apache:master Apr 10, 2024
lhotari pushed a commit that referenced this pull request Apr 22, 2024
Co-authored-by: ceceezhang <ceceezhang@tencent.com>
(cherry picked from commit cea1a9b)
lhotari pushed a commit that referenced this pull request Apr 22, 2024
Co-authored-by: ceceezhang <ceceezhang@tencent.com>
(cherry picked from commit cea1a9b)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
Co-authored-by: ceceezhang <ceceezhang@tencent.com>
(cherry picked from commit cea1a9b)
(cherry picked from commit b41e752)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
Co-authored-by: ceceezhang <ceceezhang@tencent.com>
(cherry picked from commit cea1a9b)
(cherry picked from commit b41e752)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Co-authored-by: ceceezhang <ceceezhang@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants