[fix][broker] Fix consumer stops receiving messages when with large backlogs processing#22454
Merged
Conversation
dao-jun
approved these changes
Apr 7, 2024
lhotari
requested changes
Apr 8, 2024
Member
|
Great work on this fix @Technoboy- ! Just one minor comment in #22454 (comment) . |
3 tasks
lhotari
reviewed
Apr 8, 2024
codelipenghui
approved these changes
Apr 8, 2024
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 8, 2024
…acklogs processing (apache#22454)
Technoboy-
added a commit
that referenced
this pull request
Apr 8, 2024
…acklogs processing (#22454)
lhotari
reviewed
Apr 8, 2024
|
|
||
| if (dispatcher != null && dispatcher.getConsumers().isEmpty()) { | ||
| deactivateCursor(); | ||
| topic.getManagedLedger().removeWaitingCursor(cursor); |
Member
There was a problem hiding this comment.
just wondering about this removal now after the PR has been merged. It seems that whatever isResetCursor means that it would be skipped in that case. @Technoboy- is that a problem?
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…acklogs processing (apache#22454) (cherry picked from commit 40329ee)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…acklogs processing (apache#22454) (cherry picked from commit 40329ee)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…acklogs processing (apache#22454) (cherry picked from commit 40329ee)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…acklogs processing (apache#22454) (cherry picked from commit 40329ee)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…acklogs processing (apache#22454) (cherry picked from commit 40329ee)
3 tasks
3 tasks
3 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…acklogs processing (apache#22454)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22435
Motivation
When the backlog size >
managedLedgerCursorBackloggedThreshold(default 1000), the cursor will be set inactive first. so this will cause the non-durable cursor not to add to thewaiting cursor.This leads to the consumer stopping to receive messages.pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Lines 3082 to 3090 in 2469b97
pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
Lines 3816 to 3824 in 2469b97
Documentation
docdoc-requireddoc-not-neededdoc-complete