[fix][broker] Update TransferShedder underloaded broker check to consider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check#22321
Merged
heesung-sohn merged 1 commit intoApr 3, 2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22321 +/- ##
============================================
+ Coverage 73.57% 73.80% +0.22%
+ Complexity 32624 32418 -206
============================================
Files 1877 1885 +8
Lines 139502 139881 +379
Branches 15299 15321 +22
============================================
+ Hits 102638 103235 +597
+ Misses 28908 28664 -244
- Partials 7956 7982 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9eb7318 to
f4ab491
Compare
Contributor
Author
|
Hi, @mattisonchao I saw you merged this PR , #22379. Can we also merge this too? It appears that CI is broken now? |
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check
f4ab491 to
1105476
Compare
heesung-sohn
added a commit
to heesung-sohn/pulsar
that referenced
this pull request
Apr 3, 2024
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (cherry picked from commit d7d5452)
heesung-sohn
added a commit
to heesung-sohn/pulsar
that referenced
this pull request
Apr 3, 2024
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (cherry picked from commit d7d5452)
heesung-sohn
added a commit
to heesung-sohn/pulsar
that referenced
this pull request
Apr 3, 2024
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (cherry picked from commit d7d5452)
heesung-sohn
added a commit
to heesung-sohn/pulsar
that referenced
this pull request
Apr 3, 2024
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (cherry picked from commit d7d5452)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 5, 2024
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (apache#22417) (cherry picked from commit 651908a)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 8, 2024
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321) (apache#22417) (cherry picked from commit 651908a)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…ider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check (apache#22321)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Checking zero traffic is not practical to identify if a broker is too underloaded or not(when first joining the cluster). There might be some health-checking traffic, which might make the broker's traffic slightly bigger than 1 byte/s. We better consider some relative measurements to check if a broker is significantly underloaded.
Modifications
isLoadManagerExtensionEnabled(ServiceConfiguration conf)to use onlyisLoadManagerExtensionEnabled(PulsarService pulsar)funcVerifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: