Skip to content

[fix][broker] Fix getMessageById throws 500#21919

Merged
nodece merged 1 commit into
apache:masterfrom
nodece:fix-get-messages-by-id-500
Jan 19, 2024
Merged

[fix][broker] Fix getMessageById throws 500#21919
nodece merged 1 commit into
apache:masterfrom
nodece:fix-get-messages-by-id-500

Conversation

@nodece

@nodece nodece commented Jan 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

When using bin/pulsar-admin topics get-message-by-id public/default/my-topic-1 -e 0 -l 1024 with a non-existent ledger, I expect to throw the 400 error instead of 500.

CLI log:

$ bin/pulsar-admin topics get-message-by-id public/default/my-topic-1 -e 0 -l 1024

 --- An unexpected error occurred in the server ---

Message: Message not found, the ledgerId does not belong to this topic or has been deleted

Stacktrace:

org.apache.bookkeeper.mledger.ManagedLedgerException$LedgerNotExistException: Message not found, the ledgerId does not belong to this topic or has been deleted


Reason: 
 --- An unexpected error occurred in the server ---

Message: Message not found, the ledgerId does not belong to this topic or has been deleted

Stacktrace:

org.apache.bookkeeper.mledger.ManagedLedgerException$LedgerNotExistException: Message not found, the ledgerId does not belong to this topic or has been deleted

Broker log:

2024-01-18T18:03:46,824+0800 [pulsar-web-47-14] INFO  org.eclipse.jetty.server.RequestLog - 127.0.0.1 - - [18/1月/2024:18:03:46 +0800] "GET /admin/v2/persistent/public/default/my-topic-1/ledger/1024/entry/0 HTTP/1.1" 500 340 "-" "Pulsar-Java-v3.2.0" 29

Modifications

  • In the internalGetMessageById, when readEntryFailed returns LedgerNotExitException, convert this exception to 400 error.
  • When the admin receives the 400 error, skip handle recovery.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 18, 2024
@nodece nodece closed this Jan 18, 2024
@nodece nodece reopened this Jan 18, 2024
@nodece
[fix][broker] Fix getMessageById throws 500
3efd4a6 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece force-pushed the fix-get-messages-by-id-500 branch from 7000cf4 to 3efd4a6 Compare January 18, 2024 11:12
dao-jun
dao-jun approved these changes Jan 18, 2024
View reviewed changes

@dao-jun dao-jun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodece

nodece commented Jan 18, 2024

Copy link
Copy Markdown
Member Author

/pulsarbot rerun-failure-checks

@nodece nodece added this to the 3.3.0 milestone Jan 18, 2024
@nodece nodece merged commit 55520bd into apache:master Jan 19, 2024
@Technoboy- Technoboy- modified the milestones: 3.3.0, 3.2.0 Jan 22, 2024
Technoboy- pushed a commit that referenced this pull request Jan 22, 2024
@nodece @Technoboy-
[fix][broker] Fix getMessageById throws 500 (#21919)
bca08d9 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Technoboy- pushed a commit that referenced this pull request Jan 31, 2024
@nodece @Technoboy-
[fix][broker] Fix getMessageById throws 500 (#21919)
6f7b9d9 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Technoboy- pushed a commit that referenced this pull request Feb 5, 2024
@nodece @Technoboy-
[fix][broker] Fix getMessageById throws 500 (#21919)
e8bb6ca 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 1, 2024
@nodece @mukesh-ctds
[fix][broker] Fix getMessageById throws 500 (apache#21919)
c7e481a 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 6f7b9d9)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 6, 2024
@nodece @mukesh-ctds
[fix][broker] Fix getMessageById throws 500 (apache#21919)
08e3cbe 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 6f7b9d9)
nodece added a commit to ascentstream/pulsar that referenced this pull request Dec 18, 2024
@nodece
[fix][broker] Fix getMessageById throws 500 (apache#21919)
89b300c 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 55520bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dao-jun dao-jun dao-jun approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

@liudezhi2098 liudezhi2098 Awaiting requested review from liudezhi2098

Assignees

@nodece nodece

Labels

cherry-picked/branch-3.0 cherry-picked/branch-3.1 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.3 release/3.1.3

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nodece @dao-jun @Technoboy-