[improve][pip] PIP-323: Complete Backlog Quota Telemetry#21709
Merged
Conversation
Contributor
Author
|
This PIP is based on #19601 |
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
It's a nice proposal with a clear background, and easy to read.
Just left a few minor comments
yuweisung
reviewed
Dec 12, 2023
yuweisung
left a comment
There was a problem hiding this comment.
Look good to me.
Thanks for this pip.
codelipenghui
approved these changes
Dec 13, 2023
Contributor
|
File name should be pip-323 |
Contributor
Author
@Technoboy- What am I missing? |
Contributor
Ah, sorry. |
Contributor
|
Need to update the vote thread |
Technoboy-
approved these changes
Dec 14, 2023
liudezhi2098
approved these changes
Dec 20, 2023
Contributor
Author
|
@Technoboy- Can you please merge this? The PIP vote approved it. |
15 tasks
4 tasks
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PIP-323 is introduced to fill the gap of backlog quota telemetry. It allows the user to know when a time-based backlog quota is about to exceed, and how many times it exceeded. It also adds backlog quota check duration metric allowing the user to configure the interval for that check based on data. Once this is implemented, the user can finally create and alert to know when a certain topic is about to exceed its defined backlog quota limit, alert on it, and using topic stats Admin API to grab the subscription name causing it.
Modifications
Adding PIP-323
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete