Skip to content

[cleanup][broker] Remove internalGetListAsync and validatePartitionTopicUpdateAsync#21699

Merged
nodece merged 1 commit into
apache:masterfrom
nodece:cleanup-internalGetListAsync
Dec 11, 2023
Merged

[cleanup][broker] Remove internalGetListAsync and validatePartitionTopicUpdateAsync#21699
nodece merged 1 commit into
apache:masterfrom
nodece:cleanup-internalGetListAsync

Conversation

@nodece

@nodece nodece commented Dec 8, 2023

Copy link
Copy Markdown
Member

Motivation

internalGetListAsync and validatePartitionTopicUpdateAsync methods are unused.

Modifications

Remove internalGetListAsync and validatePartitionTopicUpdateAsync methods.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

…picUpdateAsync

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Dec 8, 2023
@Technoboy-

Copy link
Copy Markdown
Contributor

Do you know which pr makes validatePartitionTopicUpdateAsync to be unused ?

@Technoboy- Technoboy- added this to the 3.2.0 milestone Dec 11, 2023
@Technoboy- Technoboy- added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/admin ready-to-test labels Dec 11, 2023
@nodece

nodece commented Dec 11, 2023

Copy link
Copy Markdown
Member Author

Do you know which pr makes validatePartitionTopicUpdateAsync to be unused ?

See #19166

@Technoboy- Technoboy- closed this Dec 11, 2023
@Technoboy- Technoboy- reopened this Dec 11, 2023
@codecov-commenter

codecov-commenter commented Dec 11, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.38%. Comparing base (2e31e71) to head (94efcd0).
Report is 767 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21699      +/-   ##
============================================
- Coverage     73.40%   73.38%   -0.03%     
- Complexity    32662    32667       +5     
============================================
  Files          1893     1893              
  Lines        140767   140714      -53     
  Branches      15506    15502       -4     
============================================
- Hits         103328   103257      -71     
- Misses        29321    29351      +30     
+ Partials       8118     8106      -12     
Flag Coverage Δ
inttests 24.10% <ø> (-0.04%) ⬇️
systests 24.73% <ø> (-0.24%) ⬇️
unittests 72.68% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pulsar/broker/admin/impl/PersistentTopicsBase.java 64.96% <ø> (+0.55%) ⬆️

... and 77 files with indirect coverage changes

@nodece nodece merged commit 51fc406 into apache:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants