Skip to content

[improve][pip] PIP-320: OpenTelemetry Scaffolding#21635

Merged
lhotari merged 10 commits into
apache:masterfrom
asafm:pip-metrics-scaffolding
Dec 13, 2023
Merged

[improve][pip] PIP-320: OpenTelemetry Scaffolding#21635
lhotari merged 10 commits into
apache:masterfrom
asafm:pip-metrics-scaffolding

Conversation

@asafm

@asafm asafm commented Nov 28, 2023 •
edited by liangyepianzhou
Loading

Copy link
Copy Markdown
Contributor

Motivation

Adding PIP-320, which a sub-PIP of PIP-264 (Implementation tracked at #21121).
This PIP is about adding the infrastructure to use OpenTelemetry in Pulsar broker, proxy and function worker.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions

github-actions Bot commented Nov 28, 2023

Copy link
Copy Markdown

@asafm Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions Bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 28, 2023
loicberthou
loicberthou reviewed Dec 6, 2023
View reviewed changes
Comment thread pip/pip-320.md
visortelle
visortelle reviewed Dec 6, 2023
View reviewed changes
Comment thread pip/pip-320.md Outdated
visortelle
visortelle reviewed Dec 6, 2023
View reviewed changes
Comment thread pip/pip-320.md
visortelle
visortelle reviewed Dec 6, 2023
View reviewed changes
Comment thread pip/pip-320.md
visortelle
visortelle reviewed Dec 6, 2023
View reviewed changes
Comment thread pip/pip-320.md
@visortelle

visortelle commented Dec 6, 2023

Copy link
Copy Markdown
Member

I left some comments. Asked questions I was interested in during the reading.
Don't consider it a review. I’m not deep enough into the metrics/OTel topic to leave comments that may be considered as a review.

Apurva007
Apurva007 reviewed Dec 7, 2023
View reviewed changes

@Apurva007 Apurva007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small clarifications needed. Overall looks good.

Comment thread pip/pip-320.md Outdated
Comment thread pip/pip-320.md
Comment thread pip/pip-320.md
BewareMyPower
BewareMyPower reviewed Dec 8, 2023
View reviewed changes
Comment thread pip/pip-320.md Outdated
@BewareMyPower

BewareMyPower commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

LGTM

Apurva007
Apurva007 approved these changes Dec 11, 2023
View reviewed changes

@Apurva007 Apurva007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asafm

asafm commented Dec 13, 2023

Copy link
Copy Markdown
Contributor Author

@lhotari The vote has been concluded and approved. Can you merge it?

@lhotari lhotari merged commit 2f9eefe into apache:master Dec 13, 2023
@asafm asafm deleted the pip-metrics-scaffolding branch December 13, 2023 19:27
@Technoboy- Technoboy- added this to the 3.2.0 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@visortelle visortelle visortelle left review comments

@BewareMyPower BewareMyPower BewareMyPower left review comments

@lhotari lhotari lhotari approved these changes

+2 more reviewers

@loicberthou loicberthou loicberthou left review comments

@Apurva007 Apurva007 Apurva007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@asafm asafm

Labels

doc-not-needed Your PR changes do not impact docs type/PIP

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@asafm @visortelle @BewareMyPower @lhotari @loicberthou @Apurva007 @Technoboy-