[improve][pip] PIP-315: Configurable max delay limit for delayed delivery#21490
Merged
Conversation
|
@KevinLiLu Please add the following content to your PR description and select a checkbox: |
- Section on consumer impact - Alternative to fix consumer impact
Contributor
Author
|
Hi @codelipenghui @jiazhai @merlimat @coderzc @wolfstudy @315157973, I saw you worked on delayed delivery code in the past. Would you mind providing some thoughts on this PIP? Thanks! |
Contributor
Author
|
Hi @lhotari @tisonkun @mattisonchao @rdhabalia @poorbarcode @Technoboy- , could you review this PIP when you get a chance? Thanks! |
315157973
reviewed
Nov 8, 2023
coderzc
reviewed
Nov 13, 2023
coderzc
approved these changes
Nov 14, 2023
Contributor
|
This proposal needs to be voted in dev mail list at first |
Contributor
Author
|
Hi @315157973 @coderzc, I have started the vote thread and added the link. |
lhotari
approved these changes
Nov 29, 2023
lhotari
left a comment
Member
There was a problem hiding this comment.
Great work, @KevinLiLu! This is a very well written PIP. I'll follow up on the voting thread soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIP-315: Configurable max delay limit for delayed delivery
Motivation
Currently there is no max delay limit so a producer can specify any delay when publishing a message.
The purpose of this PIP is to introduce an optional configuration to limit the max allowed delay for delayed delivery.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: