[improve][pip] PIP-313 Support force unsubscribe using consumer api#21452
Merged
Conversation
Contributor
|
Whether it would be more appropriate to add automatic cleaning subscribers, similar to automatically deleting inactive topics? |
Contributor
Author
Inactive topic doesn't have any sub but here in this case, when pulsar spout tries to unsubscribe on a shared sub, unsubscribe request fails first and it will also not close the consumer. so, in this case, both sub and consumer are still live and we should not perform any auto cleanup on such uncertain state. |
15 tasks
asafm
reviewed
Dec 7, 2023
| @@ -0,0 +1,74 @@ | |||
| # PIP-313: Support force unsubscribe using consumer api | |||
Contributor
There was a problem hiding this comment.
filename should be pip-313.md
Technoboy-
reviewed
Dec 11, 2023
Technoboy-
left a comment
Contributor
There was a problem hiding this comment.
Please update the vote thread link
BewareMyPower
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21451
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: