Skip to content

[improve][pip] PIP-305: Customize DNS servers to use for Pulsar Client#21352

Merged
tisonkun merged 4 commits into
apache:masterfrom
diegosalvi:pip-305
Oct 24, 2023
Merged

[improve][pip] PIP-305: Customize DNS servers to use for Pulsar Client#21352
tisonkun merged 4 commits into
apache:masterfrom
diegosalvi:pip-305

Conversation

@diegosalvi

@diegosalvi diegosalvi commented Oct 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

A PIP for making Pulsar Client used DNS servers configurable.

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: #21227

@github-actions

github-actions Bot commented Oct 12, 2023

Copy link
Copy Markdown

@diegosalvi Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions Bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Oct 12, 2023
@nodece

nodece commented Oct 13, 2023

Copy link
Copy Markdown
Member

+1

tisonkun
tisonkun approved these changes Oct 16, 2023
View reviewed changes

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! +1 binding

@diegosalvi diegosalvi changed the title [improve][pip] PIP-305: Customize DNSes to use for Pulsar Client [improve][pip] PIP-305: Customize DNS servers to use for Pulsar Client Oct 17, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Oct 19, 2023
@tisonkun

tisonkun commented Oct 24, 2023

Copy link
Copy Markdown
Member

PIP vote passed. Merging...

@tisonkun tisonkun merged commit 6947b7f into apache:master Oct 24, 2023
@tisonkun tisonkun mentioned this pull request Oct 24, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@tisonkun tisonkun tisonkun approved these changes

@lhotari lhotari Awaiting requested review from lhotari

@eolivelli eolivelli Awaiting requested review from eolivelli

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

@mattisonchao mattisonchao Awaiting requested review from mattisonchao

Assignees

No one assigned

Labels

doc-not-needed Your PR changes do not impact docs type/PIP

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@diegosalvi @nodece @tisonkun @Technoboy-