[improve][pip] PIP-286: Make the TopicCompactionService to support find entry based on publishTime or index#20867
Merged
Merged
Conversation
15 tasks
findNewestPosition method in the TopicCompactionService APIfindNewestPosition method in the TopicCompactionService API
Contributor
|
If your number is off. Newest one I see before you is 288 |
Member
Author
But I didn't find PIP-286 in the previous PR |
Contributor
|
I understand, but better to have holes than go back and forth. |
findNewestPosition method in the TopicCompactionService APIfindFirstEntryMetadata method in the TopicCompactionService API
06e7968 to
aafceef
Compare
aafceef to
04d3824
Compare
9ce18bb to
031d24e
Compare
findFirstEntryMetadata method in the TopicCompactionService API
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
Please check the comment and I think you can start the VOTE for now.
15 tasks
codelipenghui
approved these changes
Sep 26, 2023
Member
Author
|
The vote has already closed, please see: https://lists.apache.org/thread/q27zg49mpr8otwh29s3sncdcx8ly7ws6 |
liangyuanpeng
pushed a commit
to liangyuanpeng/pulsar
that referenced
this pull request
Oct 11, 2023
…nd entry based on publishTime or index (apache#20867)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: