GH-2939: Update PULL_REQUEST_TEMPLATE#2940
Merged
Fokko merged 2 commits intoapache:masterfrom Jul 8, 2024
Merged
Conversation
Member
Author
|
@rok @gszadovszky @Fokko @julienledem Would you mind taking a look? |
Fokko
reviewed
Jul 3, 2024
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Thanks for picking this up @wgtmac
I left a few comments. My personal preference is that these PR templates should be as short and concise as possible. I think that our old template is already a bit on the long side. My feeling is that people don't read them when they become too long. That's why I'm a bit of a nit-pick on the wording, sorry for that. I also suggested removing the markdown from the comments, since they won't render anyway.
Let me know what you think!
gszadovszky
reviewed
Jul 3, 2024
Member
Author
|
Thanks for the suggestion! I've simplified the wording and removed unimportant comments. PTAL. @Fokko @gszadovszky |
Member
Author
|
@Fokko Gentle ping :) |
Member
Author
|
Thanks @Fokko for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The original PR template is a little bit out of date, especially after moving from JIRA to Github issue.
What changes are included in this PR?
Update PULL_REQUEST_TEMPLATE to remove unnecessary check boxes and follow what Apache Arrow does.
Are these changes tested?
This is not a code change.
Are there any user-facing changes?
No.
Closes #2939