Conversation
52b7ee1 to
21c4c7d
Compare
|
Welcome 👋 and thx @alsmolarczyk for providing your input. I used it as a reference for the Polish language. 1 of 3 examples was tagged perfectly, 1 fits with small adjustments, and 1 requires your feedback. Please check line 128 of You tagged it as: I've left a TODO for now, until we've heard your feedback. |
- EN (dev-manual) - CA (by @kinow) - DE (ud data) - PT (ud data)
21c4c7d to
235f503
Compare
Hello @mawiesne, |
…munity provided by: @alsmolarczyk, a native speaker of the Polish language - adjusts tests assumption for 1 PL example after clearance via @alsmolarczyk, see PR discussion
235f503 to
9772ea2
Compare
|
@alsmolarczyk Thx for the feedback. I've resolved the remaining TODO and update the PR to be ready for merge. Please feel free to approve the PR from your side as well. FYI: @kinow / @jzonthemtn |
Change
POSTaggerMEITwith sample sentences for:Checks
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.