OPENNLP-287: Extend POS Tagger documentation with more information about the tag dictionary#754
Merged
mawiesne merged 1 commit intoapache:mainfrom Mar 20, 2025
Merged
Conversation
…ut the tag dictionary
Contributor
Author
|
Post changes, the rendered documentation (for Tag Dictionary section) looks like this - |
Contributor
Author
|
Hi @kottmann - Would you like to review this one and share comments? |
Contributor
|
Thanks @NishantShri4! Definitely a gap in the documentation. This looks good to me. I admit I did not run the example code though. |
jzonthemtn
approved these changes
Mar 19, 2025
mawiesne
approved these changes
Mar 19, 2025
Contributor
mawiesne
left a comment
There was a problem hiding this comment.
Thx a lot @NishantShri4 for your first contribution to Apache OpenNLP! Highly welcome and a valuable addition to the dev manual! I've projected that issue for the upcoming maintenance release 2.5.4
atarora
approved these changes
Mar 19, 2025
Contributor
atarora
left a comment
There was a problem hiding this comment.
Looks good ! Thank you !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.