Skip to content

OPENNLP-1694: Enhance JavaDoc in util.featuregen package#739

Merged
mawiesne merged 1 commit intomainfrom
OPENNLP-1694-Enhance-JavaDoc-in-util.featuregen-package
Jan 16, 2025
Merged

OPENNLP-1694: Enhance JavaDoc in util.featuregen package#739
mawiesne merged 1 commit intomainfrom
OPENNLP-1694-Enhance-JavaDoc-in-util.featuregen-package

Conversation

@mawiesne
Copy link
Contributor

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne added the documentation Pull requests that update documentation label Jan 13, 2025
@mawiesne mawiesne self-assigned this Jan 13, 2025
@mawiesne mawiesne force-pushed the OPENNLP-1694-Enhance-JavaDoc-in-util.featuregen-package branch from ff8fbbb to 097abca Compare January 13, 2025 15:57
@mawiesne mawiesne force-pushed the OPENNLP-1694-Enhance-JavaDoc-in-util.featuregen-package branch from 097abca to 97b93fe Compare January 14, 2025 10:38
@mawiesne mawiesne requested a review from rzo1 January 14, 2025 10:39
@mawiesne mawiesne merged commit 2690b88 into main Jan 16, 2025
@mawiesne mawiesne deleted the OPENNLP-1694-Enhance-JavaDoc-in-util.featuregen-package branch January 16, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests that update documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants