Skip to content

feat(services/koofr): set test for koofr#4050

Merged
Xuanwo merged 8 commits intomainfrom
koofr-test
Jan 24, 2024
Merged

feat(services/koofr): set test for koofr#4050
Xuanwo merged 8 commits intomainfrom
koofr-test

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jan 22, 2024
@suyanhanx
Copy link
Copy Markdown
Member Author

@hoslo
I found that the copy function may have problems when executing the copy tests in multiple threads.
The other tests are fine. Only the copy tests only pass when test_threads is 1.

Could you help me to take a look?

@hoslo
Copy link
Copy Markdown
Contributor

hoslo commented Jan 24, 2024

test_threads

@hoslo I found that the copy function may have problems when executing the copy tests in multiple threads. The other tests are fine. Only the copy tests only pass when test_threads is 1.

Could you help me to take a look?

When test_threads is not 1, it is possible to create an existing dir, in which case koofr will return 400, which we should consider a success.

@Xuanwo Xuanwo closed this in #4062 Jan 24, 2024
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Jan 24, 2024

Oh, fixes #xxx will close a pr directly...

@Xuanwo Xuanwo reopened this Jan 24, 2024
@github-actions github-actions bot requested review from G-XD and oowl January 24, 2024 04:37
@hoslo
Copy link
Copy Markdown
Contributor

hoslo commented Jan 24, 2024

Oh, fixes #xxx will close a pr directly...

Yes, I should just paste it.

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit a0a917f into main Jan 24, 2024
@Xuanwo Xuanwo deleted the koofr-test branch January 24, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants