chore(bindings/ocaml): pinning OCaml binding opendal version for release#4086
Merged
Xuanwo merged 1 commit intoapache:mainfrom Jan 28, 2024
Merged
chore(bindings/ocaml): pinning OCaml binding opendal version for release#4086Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
Member
How about starting another issue to discuss the ocaml release process? We need to find way to make it integrate well with our ASF release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4057
In this issue we discussed the release issue of OCaml binding. One solution is the current PR.
In this PR, the version of opendal is fixed so that the core directory is not required when building, so that when releasing, we can package this binding code separately.
At the same time, this PR also tested the results of building different OCaml versions and modified the OCaml version restrictions.
After this PR is merged, release OCaml binding requires the following steps:
bindings/ocamlseparately into something similar toapache-opendal-$release_version-binding-ocaml-src.tar.gz, and create itssha512hash.opendal.opamfile in binding/ocaml and append the following codehttps://github.com/ocaml/opam-repositoryto submit a PR. The content is theopendal.opamfile modified in the previous step.