[MWRAPPER-161] Improve script directory detection when using sh mvnw#329
Merged
slawekjaranowski merged 4 commits intoapache:masterfrom Jul 9, 2025
Merged
Conversation
This PR fixes an issue where the Maven wrapper script (mvnw) incorrectly detects its directory when invoked via sh mvnw. The updated logic ensures reliable detection of the script’s location in all supported usage scenarios. Fixes: apache#305
Add an integration test that runs `sh mvnw`.
Member
|
please add to IT |
The integration test relies on `/bin/sh`, which is not available by default on Windows systems. While some environments may provide a compatible shell, this cannot be assumed across all Windows setups, making the test unreliable on that platform. Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com>
Contributor
Author
Nice suggestion! 💯 I applied it in 8ade67f |
Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com>
slawekjaranowski
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Maven wrapper script (mvnw) incorrectly detects its directory when invoked via sh mvnw. The updated logic ensures reliable detection of the script’s location in all supported usage scenarios.
Fixes: #305
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).