Skip to content

[MWRAPPER-153] - Fixed only-mvnw.cmd fails when FIPS mode is enabled on Windows hosts#157

Merged
slachiewicz merged 1 commit intoapache:masterfrom
zbalkan:master
Dec 14, 2024
Merged

[MWRAPPER-153] - Fixed only-mvnw.cmd fails when FIPS mode is enabled on Windows hosts#157
slachiewicz merged 1 commit intoapache:masterfrom
zbalkan:master

Conversation

@zbalkan
Copy link
Contributor

@zbalkan zbalkan commented Oct 28, 2024

The script fails on Windows when FIPS mode is enabled. SHA256 enables working properly. The details are described on the JIRA ticket.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

The script fails on Windows when FIPS mode is enabled. SHA256 enables working properly.
@slachiewicz slachiewicz changed the title [MWRAPPER-XXX] - Fixed only-mvnw.cmd fails when FIPS mode is enabled on Windows hosts [MWRAPPER-153] - Fixed only-mvnw.cmd fails when FIPS mode is enabled on Windows hosts Dec 14, 2024
@slachiewicz slachiewicz merged commit 8a43246 into apache:master Dec 14, 2024
@slachiewicz slachiewicz added the enhancement New feature or request label Dec 14, 2024
@jira-importer
Copy link

Resolve #318

3 similar comments
@jira-importer
Copy link

Resolve #318

@jira-importer
Copy link

Resolve #318

@jira-importer
Copy link

Resolve #318

@slawekjaranowski slawekjaranowski added this to the 3.3.3 milestone Jul 25, 2025
@slawekjaranowski slawekjaranowski added bug Something isn't working and removed enhancement New feature or request labels Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants