[MWRAPPER-143] - The wrapperVersion property is not used in only-script mode by bdemers · Pull Request #145 · apache/maven-wrapper

bdemers · 2024-06-17T15:04:11Z

The only-script mode doesn't use the wrapper distribution, this property is now only added to the maven-wrapper.properties file when other types are used.

Following this checklist to help us incorporate your
contribution quickly and easily:

Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,
where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

Fixes #291

jira-importer · 2025-06-14T09:50:39Z

Resolve #291

jira-importer · 2025-06-14T09:55:41Z

Resolve #291

The sh_type_only-script integration test was expecting the wrapperVersion property to be present in only-script mode, but PR apache#145 removed this property from only-script mode since it's not used. Updated the test to match the expected behavior.

… mode The only-script mode doesn't use the wrapper distribution, this property is now only added to the maven-wrapper.properties file when other types are used.

cstamas · 2025-08-30T21:15:40Z

Original issue that added version:
https://issues.apache.org/jira/browse/MWRAPPER-134

So, the intent of the version in the properties file was in fact to ease various automations to detect, and maybe suggest an upgrade for wrapper itself. We are now breaking automations for the second time...

Hence, this PR is wrong. And sorry for being late to the party.

GreyTeardrop · 2025-08-31T16:14:30Z

I'm in the same boat as @cstamas - only discovered this change when Renovate created an upgrade PR for Maven Wrapper to version 3.3.3 which removes the wrapperVersion property. If that PR gets merged, there won't be an easy way to get another update PR without a manual change. Please, consider rolling back this change…

breun · 2025-09-02T06:26:44Z

For update automation tools need a reliable way to determine the current version of Maven Wrapper. The wrapperVersion property was a way, although admittedly flawed, because I encounter a lot of projects with wrapperVersion bumped manually, but the mvnw* scripts from a much older version, because they were not updated along with the property.

I saw that Renovate plans to determine the Maven Wrapper version based on a regex check on the scripts themselves (renovatebot/renovate#37779), which should be more reliable than reading wrapperVersion, as long as the format of that comment line it’s parsed from doesn’t change, so it’s still a fragile method.

Could Maven Wrapper provide its version in a more robust (machine-readable) way?

slawekjaranowski · 2025-09-02T06:36:23Z

@breun please comments in open linked issue

breun · 2025-09-02T06:47:49Z

@breun please comments in open linked issue

Ok, comment reposted here: #364 (comment)

…nly-script mode (apache#145)" This reverts commit 91bdb45.

* Revert "[MWRAPPER-143] - The wrapperVersion property is not used in only-script mode (#145)" This reverts commit 91bdb45. * Revert #145, but leave wrapperUrl assertions

ghost · 2026-01-16T06:12:42Z

The only-script mode doesn't use the wrapper distribution, this property is now only added to the maven-wrapper.properties file when other types are used.

Following this checklist to help us incorporate your
contribution quickly and easily:

Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.

Each commit in the pull request should have a meaningful subject line and body.

Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,
where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.

Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.

You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

In any other case, please file an Apache Individual Contributor License Agreement.

Fixes #291

ghost · 2026-01-16T06:12:56Z

Solve

bdemers changed the title ~~[MWRAPPER-143] The wrapperVersion property is not used in only-script mode~~ [MWRAPPER-143] - The wrapperVersion property is not used in only-script mode Jun 17, 2024

slachiewicz added the bug Something isn't working label Dec 16, 2024

gnodet approved these changes Jul 18, 2025

View reviewed changes

bdemers and others added 2 commits August 15, 2025 15:58

[MWRAPPER-143] The wrapperVersion property is not used in only-script…

13e63db

… mode The only-script mode doesn't use the wrapper distribution, this property is now only added to the maven-wrapper.properties file when other types are used.

fix it

2c69885

slawekjaranowski force-pushed the MWRAPPER-143-bdemers branch from 2e049d2 to 2c69885 Compare August 15, 2025 14:05

slawekjaranowski approved these changes Aug 15, 2025

View reviewed changes

slawekjaranowski merged commit 91bdb45 into master Aug 15, 2025
53 checks passed

slawekjaranowski deleted the MWRAPPER-143-bdemers branch August 15, 2025 17:36

jira-importer mentioned this pull request Jun 17, 2024

[MWRAPPER-143] Maven wrapper plugin should not create wrapperVersion property for script-only mode #291

Closed

github-actions bot assigned slawekjaranowski Aug 15, 2025

github-actions bot added this to the 3.3.3 milestone Aug 15, 2025

slawekjaranowski mentioned this pull request Sep 2, 2025

wrapperVersion property gets removed when upgrading to Maven Wrapper 3.3.3 #364

Closed

breun mentioned this pull request Sep 2, 2025

feat(manager/maven-wrapper): extract wrapper version from mvnw script file renovatebot/renovate#37779

Merged

12 tasks

breun added a commit to breun/maven-wrapper that referenced this pull request Sep 2, 2025

Revert "[MWRAPPER-143] - The wrapperVersion property is not used in o…

25d97a6

…nly-script mode (apache#145)" This reverts commit 91bdb45.

breun added a commit to breun/maven-wrapper that referenced this pull request Sep 2, 2025

Revert apache#145, but leave wrapperUrl assertions

15fceea

breun mentioned this pull request Sep 2, 2025

Revert wrapper version removal #365

Merged

ghost approved these changes Jan 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MWRAPPER-143] - The wrapperVersion property is not used in only-script mode#145

[MWRAPPER-143] - The wrapperVersion property is not used in only-script mode#145
slawekjaranowski merged 2 commits intomasterfrom
MWRAPPER-143-bdemers

bdemers commented Jun 17, 2024 •

edited by cstamas

Loading

Uh oh!

jira-importer commented Jun 14, 2025

Uh oh!

jira-importer commented Jun 14, 2025

Uh oh!

Uh oh!

cstamas commented Aug 30, 2025 •

edited

Loading

Uh oh!

GreyTeardrop commented Aug 31, 2025

Uh oh!

breun commented Sep 2, 2025

Uh oh!

slawekjaranowski commented Sep 2, 2025

Uh oh!

breun commented Sep 2, 2025

Uh oh!

ghost commented Jan 16, 2026

Uh oh!

ghost commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

bdemers commented Jun 17, 2024 • edited by cstamas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jira-importer commented Jun 14, 2025

Uh oh!

jira-importer commented Jun 14, 2025

Uh oh!

Uh oh!

cstamas commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GreyTeardrop commented Aug 31, 2025

Uh oh!

breun commented Sep 2, 2025

Uh oh!

slawekjaranowski commented Sep 2, 2025

Uh oh!

breun commented Sep 2, 2025

Uh oh!

ghost commented Jan 16, 2026

Uh oh!

ghost commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bdemers commented Jun 17, 2024 •

edited by cstamas

Loading

cstamas commented Aug 30, 2025 •

edited

Loading